Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2228 Improve styling of accordions #151

Merged
merged 7 commits into from
Jan 25, 2024
Merged

GT-2228 Improve styling of accordions #151

merged 7 commits into from
Jan 25, 2024

Conversation

caleballdrin
Copy link
Contributor

Description

https://jira.cru.org/browse/GT-2228

  • Improve styling of accordions [1 Day]
  • Change heading font to Source Sans Pro
  • Make box more rounded
  • Add more spacing between accordions

@caleballdrin caleballdrin self-assigned this Dec 15, 2023
@caleballdrin caleballdrin added the On Staging Will be merged to the staging branch by Github Actions label Dec 15, 2023
Copy link
Contributor

I see you added the "On Staging" label, I'll get this merged to the staging branch!

Copy link
Contributor

Merge conflict attempting to merge this into staging. Please fix manually.

@caleballdrin caleballdrin requested a review from dr-bizz December 15, 2023 19:50
tool-versions Outdated Show resolved Hide resolved
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! 🔥

@caleballdrin caleballdrin requested a review from dr-bizz January 16, 2024 18:43
@dr-bizz
Copy link
Contributor

dr-bizz commented Jan 16, 2024

Something is wrong with this PR. I doubt you edited 215 files intentionally, even though you're capable of doing that.

We are no longer using new-page folder. Can you pull and merge the most recent master into your Branch?

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to merge the latest version of master into your branch to fix all the conflicts and files that should be already deleted.

caleballdrin and others added 7 commits January 17, 2024 11:46
* Adding support for asdf

* Adding github merge workflows to make development easier. merge into staging or development

* Removed the old "page" folder and components.
Removed route to view old pages.
Renamed the new page and componements to remove "New" from their name.

* Removing update-development and only using one workflow file.
Fixing some errors with branch names.
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look great. Awesome work!

@caleballdrin caleballdrin merged commit 74d66b4 into master Jan 25, 2024
4 checks passed
@caleballdrin caleballdrin deleted the fix-accordion branch January 25, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants