Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2229 Fix Prayer Pathway #153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

GT-2229 Fix Prayer Pathway #153

wants to merge 2 commits into from

Conversation

caleballdrin
Copy link
Contributor

Description

https://jira.cru.org/secure/RapidBoard.jspa?rapidView=150&view=detail&selectedIssue=GT-2229#
No way to go back from button selection (ex. "Yes") without just reloading the page
Resource button does not do anything (languages other than English & Spanish)
These both may involve fixing or changing how web deals with listeners

@caleballdrin caleballdrin added the On Staging Will be merged to the staging branch by Github Actions label Jan 23, 2024
@caleballdrin caleballdrin requested a review from dr-bizz January 23, 2024 22:24
@caleballdrin caleballdrin self-assigned this Jan 23, 2024
Copy link
Contributor

I see you added the "On Staging" label, I'll get this merged to the staging branch!

@caleballdrin caleballdrin requested a review from frett January 23, 2024 22:25
@frett
Copy link
Contributor

frett commented Jan 23, 2024

I do see you removed the specific no thanks workaround. It doesn't look like you are observing page listeners yet though.

In french KGP, when you click the "Not Ready" button, one of the buttons on the displayed card is for the resources page.
Screenshot 2024-01-23 at 3 46 39 PM

When you click this button it does nothing. that button triggers the events="resource-page-listener" event, and the final page in KGP has the correct listener defined listeners="resource-page-listener". but the web version is not jumping to that page

@dr-bizz
Copy link
Contributor

dr-bizz commented Jan 24, 2024

@frett I've created a new jira task for the page listeners error (https://jira.cru.org/browse/GT-2262), we can open a new PR to fix the page listeners

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a coding perspective, this is looking good. We will need to update the production mobile content admin to add the dismiss listeners before we push this PR. That way we can test it on staging.

@dr-bizz
Copy link
Contributor

dr-bizz commented Jan 25, 2024

It seems the mobile app also has the same issue where you click "No thanks" and it sends you to the next page. I'm assuming this isn't correct. Hopefully adding the dismiss listeners will fix that for the mobile. Or it could cause issues for Mobile. We need to talk with the God Tools mobile team to check
CC @frett

@frett
Copy link
Contributor

frett commented Jan 25, 2024

On android it goes to the next page because there is also a page listener defined on that page

@frett
Copy link
Contributor

frett commented Jan 25, 2024

So removing the no thanks hard coded path on the web should be coupled with correctly supporting page listeners

@frett
Copy link
Contributor

frett commented Jan 25, 2024

here are the various events and listeners from the KGP followup form:

followup card listeners and buttons:

    <card hidden="true" listeners="followup-form" dismiss-listeners="send-information-modal-close">

    <content:button type="event" events="followup:send send-information-modal send-information-modal-close">
    <content:button type="event" events="followup-form-no-thanks" style="outlined">

modal listeners and button:

    <modal listeners="send-information-modal" dismiss-listeners="done-information-modal-close">

    <content:button type="event" events="done-information-modal-close">

next page listeners:

    <page listeners="done-information-modal-close followup-form-no-thanks">

@frett
Copy link
Contributor

frett commented Jan 25, 2024

so right now based on the events & listeners, the no thanks button doesn't dismiss the followup form card, this is something that the content team can add if they desire that functionality. But it does trigger the page listener on the next page.

Submitting the form does dismiss the card and shows the modal, then clicking the button in the modal will dismiss the modal and trigger the listener on the next page.

@caleballdrin caleballdrin requested a review from dr-bizz February 12, 2024 21:07
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is being postponed, so I'm removing myself from being a reviewer.

We need to add the page listeners functionality onto God Tool before deploying this, which will require some dev hours.

@frett frett removed On Staging Will be merged to the staging branch by Github Actions On Development labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants