-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GT-2229 Fix Prayer Pathway #153
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Bizz <[email protected]>
I see you added the "On Staging" label, I'll get this merged to the staging branch! |
@frett I've created a new jira task for the page listeners error (https://jira.cru.org/browse/GT-2262), we can open a new PR to fix the page listeners |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a coding perspective, this is looking good. We will need to update the production mobile content admin to add the dismiss listeners
before we push this PR. That way we can test it on staging.
It seems the mobile app also has the same issue where you click "No thanks" and it sends you to the next page. I'm assuming this isn't correct. Hopefully adding the |
On android it goes to the next page because there is also a page listener defined on that page |
So removing the no thanks hard coded path on the web should be coupled with correctly supporting page listeners |
here are the various events and listeners from the KGP followup form: followup card listeners and buttons: <card hidden="true" listeners="followup-form" dismiss-listeners="send-information-modal-close">
<content:button type="event" events="followup:send send-information-modal send-information-modal-close">
<content:button type="event" events="followup-form-no-thanks" style="outlined"> modal listeners and button: <modal listeners="send-information-modal" dismiss-listeners="done-information-modal-close">
<content:button type="event" events="done-information-modal-close"> next page listeners: <page listeners="done-information-modal-close followup-form-no-thanks"> |
so right now based on the events & listeners, the no thanks button doesn't dismiss the followup form card, this is something that the content team can add if they desire that functionality. But it does trigger the page listener on the next page. Submitting the form does dismiss the card and shows the modal, then clicking the button in the modal will dismiss the modal and trigger the listener on the next page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is being postponed, so I'm removing myself from being a reviewer.
We need to add the page listeners functionality onto God Tool before deploying this, which will require some dev hours.
Description
https://jira.cru.org/secure/RapidBoard.jspa?rapidView=150&view=detail&selectedIssue=GT-2229#
No way to go back from button selection (ex. "Yes") without just reloading the page
Resource button does not do anything (languages other than English & Spanish)
These both may involve fixing or changing how web deals with listeners