GT-2440 - Change Prev/Next Buttons to A tags #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-bizz
force-pushed
the
fix-js-buttons
branch
from
5fcbf59 to
823dda4
Compare
dr-bizz
added
the
On Staging
|
I see you added the "On Staging" label, I'll get this merged to the staging branch! |
… of "javascript:void(0)", so GTM registers them as links and fires a `gtm.click` event when they are clicked.
dr-bizz
force-pushed
the
fix-js-buttons
branch
from
b506412 to
e22c08a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When embedded, Google doesn't pick up button clicks, so in this PR, I change the buttons that lead to a page change to A tags with a href="javascript:void(0)" attribute.