Adding more tests

.swiftpm/xcode/xcshareddata/xcschemes/LocalizationServices.xcscheme

@@ -27,8 +27,13 @@
       buildConfiguration = "Debug"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
-      shouldUseLaunchSchemeArgsEnv = "YES"
-      shouldAutocreateTestPlan = "YES">
+      shouldUseLaunchSchemeArgsEnv = "YES">
+      <TestPlans>
+         <TestPlanReference
+            reference = "container:Tests/LocalizationServicesTests/LocalizationServices copy.xctestplan"
+            default = "YES">
+         </TestPlanReference>
+      </TestPlans>
       <Testables>
          <TestableReference
             skipped = "NO">

Tests/LocalizationServicesTests/LocalizationServices-spanish-language.xctestplan

@@ -0,0 +1,24 @@
+{
+  "configurations" : [
+    {
+      "id" : "AC3E41B3-57AC-410E-B023-A247A5081F79",
+      "name" : "Test Scheme Action",
+      "options" : {
+
+      }
+    }
+  ],
+  "defaultOptions" : {
+    "language" : "es"
+  },
+  "testTargets" : [
+    {
+      "target" : {
+        "containerPath" : "container:",
+        "identifier" : "LocalizationServicesTests",
+        "name" : "LocalizationServicesTests"
+      }
+    }
+  ],
+  "version" : 1
+}

Tests/LocalizationServicesTests/LocalizationServices/Bundle/LocalizableStringsBundleTests.swift

@@ -25,16 +25,18 @@ class LocalizableStringsBundleTests: XCTestCase {
 
     func testEmptyKeyReturnsNil() {
 
-        XCTAssertNil(stringsBundle.stringForKey(key: ""), "Value returned should be nil.")
+        XCTAssertNil(stringsBundle.stringForKey(key: ""))
     }
 
     func testExistingPhraseReturnsAValue() {
 
-        XCTAssertEqual(stringsBundle.stringForKey(key: LocalizableStringsKeys.testValueYes.key), "yes", "Value should equal yes.")
+        // Expects System to be in Spanish.  Configured in tests.
+
+        XCTAssertEqual(stringsBundle.stringForKey(key: LocalizableStringsKeys.testValueYes.key), "Sí")
     }
 
     func testMissingPhraseReturnsANilValue() {
 
-        XCTAssertNil(stringsBundle.stringForKey(key: LocalizableStringsBundleTests.missingStringPhraseKey), "Value returned should be nil.")
+        XCTAssertNil(stringsBundle.stringForKey(key: LocalizableStringsBundleTests.missingStringPhraseKey))
     }
 }

Tests/LocalizationServicesTests/LocalizationServices/Repository/LocalizableStringsRepositoryTests.swift

@@ -57,6 +57,29 @@ class LocalizableStringsRepositoryTests: XCTestCase {
         XCTAssertEqual(localizedString, "Sí")
     }
 
+    func testStringForLocaleElseEnglishReturnsLocale() {
+
+        XCTAssertTrue(stringsRepository.stringForLocaleElseEnglish(localeIdentifier: LocaleId.spanish.id, key: "test.value.yes") == "Sí")
+    }
+
+    func testStringForLocaleElseSystemElseEnglishReturnsLocale() {
+
+        XCTAssertTrue(stringsRepository.stringForLocaleElseSystemElseEnglish(localeIdentifier: LocaleId.spanish.id, key: "test.value.yes") == "Sí")
+    }
+
+    func testStringForLocaleElseSystemElseEnglishReturnsEnglish() {
+
+        let localizedString: String? = stringsRepository.stringForLocaleElseSystemElseEnglish(localeIdentifier: LocaleId.spanish.id, key: "test.value.englishOnly")
+
+        XCTAssertTrue(localizedString == "English Only")
+    }
+
+    func testStringForLocaleReturnsNil() {
+
+        XCTAssertNil(stringsRepository.stringForLocale(localeIdentifier: nil, key: "test.value.yes"))
+        XCTAssertNil(stringsRepository.stringForLocale(localeIdentifier: "", key: "test.value.yes"))
+    }
+
     func testStringForLocaleDoesNotExist() {
 
         let localizedString: String? = stringsRepository.stringForLocale(
@@ -87,4 +110,21 @@ class LocalizableStringsRepositoryTests: XCTestCase {
 
         XCTAssertNotNil(localizedString)
     }
+
+    // MARK: - System
+
+    func testStringForSystemReturnsSpanishTranslationWhenSystemIsSpanish() {
+
+        // Expects System to be in Spanish.  Configured in tests.
+
+        XCTAssertTrue(stringsRepository.stringForSystem(key: "test.value.yes") == "Sí")
+        XCTAssertTrue(stringsRepository.stringForSystemElseEnglish(key: "test.value.yes") == "Sí")
+    }
+
+    func testStringForSystemReturnsEnglishTranslationWhenSystemTranslationDoesNotExist() {
+
+        // Expects System to be in Spanish.  Configured in tests.
+
+        XCTAssertTrue(stringsRepository.stringForSystemElseEnglish(key: "test.value.englishOnly") == "English Only")
+    }
 }

Tests/LocalizationServicesTests/Resources/LocalizableStrings/Base.lproj/Localizable.strings

@@ -1 +1,2 @@
 "test.value.yes" = "yes";
+"test.value.englishOnly" = "English Only";