Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Adding new async publish feature for single and bulk." #706

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Mar 27, 2024

Reverts #700

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Mar 27, 2024

Rolling back as API PR hasn't been deployed yet

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 40.62500% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 66.32%. Comparing base (2a80955) to head (6fb0fcb).

Files Patch % Lines
...pp/components/translation/translation.component.ts 31.25% 11 Missing ⚠️
...ft-generator/multiple-draft-generator.component.ts 46.66% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
+ Coverage   65.77%   66.32%   +0.55%     
==========================================
  Files          60       59       -1     
  Lines        1607     1482     -125     
  Branches      133      115      -18     
==========================================
- Hits         1057      983      -74     
+ Misses        524      481      -43     
+ Partials       26       18       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-bizz dr-bizz merged commit c4309dc into master Mar 27, 2024
4 checks passed
@dr-bizz dr-bizz deleted the revert-700-GT-1968-update-publishing-status branch March 27, 2024 20:36
@frett
Copy link
Contributor

frett commented Mar 27, 2024

@dr-bizz the API work was merged into master back in November CruGlobal/mobile-content-api#1370

was there something you were seeing that was failing on production?

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Mar 27, 2024

@aaronlaib told me the API PR hadn't been merged yet so rolled it back. But I didn't check myself so it could have been working.

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Mar 27, 2024

The Jira board wasn't updated which led to the confusion. I'll push the new PR live.

@aaronlaib
Copy link

@frett and @dr-bizz sorry about this. Rollback works I guess! haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants