Deduplicate selected ids

CruGlobal · Oct 4, 2024 · 2117ae9 · 2117ae9
1 parent fb108d5
commit 2117ae9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/hooks/useMassSelection.test.ts b/src/hooks/useMassSelection.test.ts
@@ -87,7 +87,7 @@ describe('useMassSelection', () => {
   });
 
   describe('selectMultipleIds()', () => {
-    it('should return what type of selection', () => {
+    it('should select multiple ids and deduplicate selected ids', () => {
       const { result, rerender } = renderHook(() =>
         useMassSelection(defaultIdsList),
       );
@@ -96,7 +96,7 @@ describe('useMassSelection', () => {
       rerender();
       expect(result.current.ids).toEqual(['1', '2', '3']);
 
-      result.current.selectMultipleIds(['4', '5', '6']);
+      result.current.selectMultipleIds(['3', '4', '5', '6']);
       rerender();
       expect(result.current.ids).toEqual(['1', '2', '3', '4', '5', '6']);
     });

diff --git a/src/hooks/useMassSelection.ts b/src/hooks/useMassSelection.ts
@@ -28,7 +28,7 @@ export const useMassSelection = (
   };
 
   const selectMultipleIds = (newIds: string[]) => {
-    setIds([...ids, ...newIds]);
+    setIds([...ids, ...newIds.filter((newId) => !ids.includes(newId))]);
   };
 
   const deselectMultipleIds = (idsToRemove: string[]) => {