Skip to content

Commit

Permalink
Unrelated to the changes in this PR, but while testing I found that I…
Browse files Browse the repository at this point in the history
… could not reach my bottom contact in the list view. This was also true on staging. Adding this extra 8px allows for me to at least reach the contact row, though it is not perfect UX.
  • Loading branch information
wrandall22 committed Aug 14, 2024
1 parent b1b56ed commit 243e693
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion src/components/Contacts/ContactsList/ContactsList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { InfiniteList } from 'src/components/InfiniteList/InfiniteList';
import { navBarHeight } from 'src/components/Layouts/Primary/Primary';
import NullState from 'src/components/Shared/Filters/NullState/NullState';
import { headerHeight } from 'src/components/Shared/Header/ListHeader';
import theme from 'src/theme';
import { ContactRow } from '../ContactRow/ContactRow';

export const ContactsList: React.FC = () => {
Expand All @@ -22,7 +23,11 @@ export const ContactsList: React.FC = () => {
<InfiniteList
loading={loading}
data={data?.contacts?.nodes ?? []}
style={{ height: `calc(100vh - ${navBarHeight} - ${headerHeight})` }}
style={{
height: `calc(100vh - ${navBarHeight} - ${headerHeight} + ${theme.spacing(
1,
)})`,
}}
itemContent={(index, contact) => (
<ContactRow
key={contact.id}
Expand All @@ -49,6 +54,7 @@ export const ContactsList: React.FC = () => {
/>
</Box>
}
increaseViewportBy={{ top: 2000, bottom: 2000 }}
/>
);
};

0 comments on commit 243e693

Please sign in to comment.