Hide next action select when there are no suggested actions

CruGlobal · Oct 3, 2024 · 7e3f166 · 7e3f166
1 parent 1940761
commit 7e3f166
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 1 deletion.
diff --git a/src/components/Task/Modal/Form/LogForm/TaskModalLogForm.test.tsx b/src/components/Task/Modal/Form/LogForm/TaskModalLogForm.test.tsx
@@ -386,6 +386,42 @@ describe('TaskModalLogForm', () => {
     expect(getByRole('combobox', { name: 'Next Action' })).toBeInTheDocument();
   });
 
+  it('hides next action for results with no suggested next actions', async () => {
+    const { getByRole, findByRole, queryByRole } = render(
+      <ThemeProvider theme={theme}>
+        <LocalizationProvider dateAdapter={AdapterLuxon}>
+          <SnackbarProvider>
+            <GqlMockedProvider<{
+              LoadConstants: LoadConstantsQuery;
+            }>
+              mocks={{
+                LoadConstants,
+              }}
+            >
+              <TaskModalLogForm
+                accountListId={accountListId}
+                onClose={jest.fn()}
+              />
+            </GqlMockedProvider>
+          </SnackbarProvider>
+        </LocalizationProvider>
+      </ThemeProvider>,
+    );
+
+    userEvent.click(getByRole('combobox', { name: 'Task Type' }));
+    userEvent.click(await findByRole('option', { name: 'Initiation' }));
+
+    userEvent.click(getByRole('combobox', { name: 'Action' }));
+    userEvent.click(await findByRole('option', { name: 'In Person' }));
+
+    userEvent.click(getByRole('combobox', { name: 'Result' }));
+    userEvent.click(await findByRole('option', { name: 'Not Interested' }));
+
+    expect(
+      queryByRole('combobox', { name: 'Next Action' }),
+    ).not.toBeInTheDocument();
+  });
+
   it('opens the next action modal', async () => {
     const mutationSpy = jest.fn();
     const onClose = jest.fn();

diff --git a/src/components/Task/Modal/Form/possibleNextActions.ts b/src/components/Task/Modal/Form/possibleNextActions.ts
@@ -20,7 +20,7 @@ export const possibleNextActions = (
       )
     : null;
 
-  return result?.suggestedNextActions
+  return result?.suggestedNextActions?.length
     ? [ActivityTypeEnum.None, ...result.suggestedNextActions]
     : [];
 };