Add check before refetching and remove saving to local storage in pre…

…ferences

src/components/Constants/UseApiConstants.tsx

@@ -14,14 +14,15 @@ export const useApiConstants = ():
   });
 
   const userSavedLanguage = data?.user.preferences?.locale;
-  const [localeStorageLanguage, setLocaleStorageLanguage] = useLocalStorage(
-    `user-language`,
+  const [localStorageLanguage, setLocalStorageLanguage] = useLocalStorage(
+    `constants-language`,
     '',
   );
   useEffect(() => {
-    // if the language in locale storage is different than the saved language, the user may have changed languages in a different browser. If so, refetch the constants.
-    if (localeStorageLanguage !== userSavedLanguage) {
-      setLocaleStorageLanguage(userSavedLanguage || '');
+    // if the language in local storage is different than the saved language, that may mean the cached constants are in the previous language. If so, refetch the constants.
+
+    if (userSavedLanguage && localStorageLanguage !== userSavedLanguage) {
+      setLocalStorageLanguage(userSavedLanguage || '');
       refetch();
     }
   }, [userSavedLanguage]);

src/components/Settings/preferences/accordions/LanguageAccordion/LanguageAccordion.tsx

@@ -9,7 +9,6 @@ import { FieldWrapper } from 'src/components/Shared/Forms/FieldWrapper';
 import { FormWrapper } from 'src/components/Shared/Forms/FormWrapper';
 import { Preference } from 'src/graphql/types.generated';
 import useGetAppSettings from 'src/hooks/useGetAppSettings';
-import { useLocalStorage } from 'src/hooks/useLocalStorage';
 import { formatLanguage, languages } from 'src/lib/data/languages';
 import { useUpdatePersonalPreferencesMutation } from '../UpdatePersonalPreferences.generated';
 
@@ -34,7 +33,6 @@ export const LanguageAccordion: React.FC<LanguageAccordionProps> = ({
   const { appName } = useGetAppSettings();
   const { enqueueSnackbar } = useSnackbar();
   const [updatePersonalPreferences] = useUpdatePersonalPreferencesMutation();
-  const [_, setLocaleStorageLanguage] = useLocalStorage(`user-language`, '');
 
   const label = t('Language');
 
@@ -57,7 +55,6 @@ export const LanguageAccordion: React.FC<LanguageAccordionProps> = ({
         enqueueSnackbar(t('Saved successfully.'), {
           variant: 'success',
         });
-        setLocaleStorageLanguage(attributes.locale || '');
       },
       onError: () => {
         enqueueSnackbar(t('Saving failed.'), {