Mpdx 7936 delete button api call (#976)

* added graphQL mutation squash * fixed add email functionality * Fix inline email address editing * Fix part of the caching issue. The way the component is using state of the emails is causing the most issues why they aren't updating. The new email gets added but replaces the last email. * added delete functionality and fixed modal issues * Do a bit of cleanup of the code * Fix up the tests now that delete is working * Removing the delete modal and using the confirmationModal instead. I also added tests and improved some of the PR. * Removed unused interface and ensured same data is returned after update. * Update and fix tests. Now testing to ensure the new email gets added by the Star icon rather than checking what gets passed into cache. --------- Co-authored-by: Collin Pastika <[email protected]> Co-authored-by: Bill Randall <[email protected]> Co-authored-by: Daniel Bisgrove <[email protected]>
CruGlobal · Aug 7, 2024 · e4b7269 · e4b7269
1 parent bc61be7
commit e4b7269
Show file tree

Hide file tree

Showing 12 changed files with 748 additions and 952 deletions.
diff --git a/src/components/Tool/FixEmailAddresses/AddEmailAddress.graphql b/src/components/Tool/FixEmailAddresses/AddEmailAddress.graphql
@@ -3,7 +3,7 @@ mutation EmailAddresses($input: PersonUpdateMutationInput!) {
     person {
       emailAddresses {
         nodes {
-          email
+          ...PersonEmailAddress
         }
       }
     }

diff --git a/src/components/Tool/FixEmailAddresses/DeleteModal.test.tsx b/src/components/Tool/FixEmailAddresses/DeleteModal.test.tsx
diff --git a/src/components/Tool/FixEmailAddresses/DeleteModal.tsx b/src/components/Tool/FixEmailAddresses/DeleteModal.tsx
diff --git a/src/components/Tool/FixEmailAddresses/EmailValidationForm.tsx b/src/components/Tool/FixEmailAddresses/EmailValidationForm.tsx
@@ -8,7 +8,7 @@ import { AddIcon } from 'src/components/Contacts/ContactDetails/ContactDetailsTa
 import { useAccountListId } from 'src/hooks/useAccountListId';
 import i18n from 'src/lib/i18n';
 import { useEmailAddressesMutation } from './AddEmailAddress.generated';
-import { RowWrapper } from './FixEmailAddressPerson';
+import { RowWrapper } from './FixEmailAddressPerson/FixEmailAddressPerson';
 import {
   GetInvalidEmailAddressesDocument,
   GetInvalidEmailAddressesQuery,
@@ -30,7 +30,6 @@ interface EmailValidationFormEmail {
 }
 
 interface EmailValidationFormProps {
-  index: number;
   personId: string;
 }
 

diff --git a/src/components/Tool/FixEmailAddresses/FixEmailAddressPerson.test.tsx b/src/components/Tool/FixEmailAddresses/FixEmailAddressPerson.test.tsx
-Original file line number
+Diff line change
@@ Expand Up / @@ -3,7 +3,7 @@ mutation EmailAddresses($input: PersonUpdateMutationInput!) { @@
         person {
           emailAddresses {
             nodes {
-              email
+              ...PersonEmailAddress
             }
           }
         }
@@ Expand Down @@