Skip to content

Commit

Permalink
MPDX-8333 Suggested Tags Fix (#1111)
Browse files Browse the repository at this point in the history
* FIx suggested tasks not geting saved on CompleteModal

* Fix showing 0 when there is no pledgeAmount

* Make description more clear

* Make Whats new button the same size as others

* Rename to Appeals

* Fix Navmenu test

* Refactor test mocks and add test to check suggested tags are saved

* Small test changes
  • Loading branch information
caleballdrin authored Oct 4, 2024
1 parent 0587cbb commit e9331a0
Show file tree
Hide file tree
Showing 11 changed files with 75 additions and 327 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const ContactHeaderStatusSection: React.FC<Props> = ({
{statusText}
{status === StatusEnum.PartnerFinancial && (
<>
{contact?.pledgeAmount && contact?.pledgeFrequency && (
{!!contact?.pledgeAmount && !!contact?.pledgeFrequency && (
<Typography variant="subtitle1">
{`${
contact.pledgeAmount && contact?.pledgeCurrency
Expand Down
2 changes: 1 addition & 1 deletion src/components/Layouts/Primary/NavBar/NavItem/NavItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export const NavItem: FC<NavItemProps> = ({
<img
src={process.env.HELP_WHATS_NEW_IMAGE_URL}
alt={t('Help logo')}
height={36}
height={24}
style={{ marginRight: theme.spacing(1) }}
/>
)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ describe('NavMenu', () => {
getByRole('menuitem', { name: 'Partner Giving Analysis' }),
).toBeInTheDocument();
userEvent.click(getByTestId('ToolsMenuToggle'));
expect(getByRole('menuitem', { name: 'Appeal' })).toBeInTheDocument();
expect(getByRole('menuitem', { name: 'Appeals' })).toBeInTheDocument();
expect(
getByRole('menuitem', { name: 'Fix Commitment Info' }),
).toBeInTheDocument();
Expand Down Expand Up @@ -124,7 +124,6 @@ describe('NavMenu', () => {
await findByRole('menuitem', { name: 'Coaching' }),
).toBeInTheDocument();
});

it('does not show coaching link if there are no coaching accounts', async () => {
const { queryByRole } = render(
<TestComponent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ const NavMenu: React.FC = () => {
<img
src={process.env.HELP_WHATS_NEW_IMAGE_URL}
alt={t('Help logo')}
height={36}
height={24}
style={{ marginRight: theme.spacing(1) }}
/>
)}
Expand Down
163 changes: 0 additions & 163 deletions src/components/Task/Modal/Form/Complete/TaskModalCompleteForm.mock.tsx

This file was deleted.

Loading

0 comments on commit e9331a0

Please sign in to comment.