Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8091 Preferences Setup steps UI #1002

Merged
merged 9 commits into from
Sep 4, 2024
Merged

MPDX-8091 Preferences Setup steps UI #1002

merged 9 commits into from
Sep 4, 2024

Conversation

caleballdrin
Copy link
Contributor

Description

https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8091

  • Add banner with skip step button
  • Accordion open functionality
  • Disable other accordions while setup is happening

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin self-assigned this Aug 20, 2024
@caleballdrin caleballdrin requested a review from canac August 20, 2024 05:11
@caleballdrin caleballdrin marked this pull request as draft August 20, 2024 05:12
@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Aug 20, 2024
Copy link
Contributor

github-actions bot commented Aug 20, 2024

Bundle sizes [mpdx-react]

Compared against e3e6a5a

Route Size (gzipped) Diff
/accountLists/[accountListId]/settings/integrations 242.52 KB +80.62 KB
/accountLists/[accountListId]/settings/notifications 221.6 KB +85.52 KB
/accountLists/[accountListId]/settings/preferences 214.42 KB +2.63 KB
/accountLists/[accountListId]/tasks/[[...contactId]] 139.54 KB +1.49 KB
Dynamic import Size (gzipped) Diff
../src/components/EditDonationModal/DynamicEditDonationModal.tsx -> ./EditDonationModal 75.62 KB +1.94 KB
../src/components/Task/Modal/Form/DynamicTaskModalForm.tsx -> ./TaskModalForm 108.38 KB +1.86 KB

Copy link
Contributor

Preview branch generated at https://sign-up-steps.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think you're definitely on the right track.

@caleballdrin caleballdrin marked this pull request as ready for review August 21, 2024 21:48
@caleballdrin caleballdrin requested a review from canac August 21, 2024 21:48
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with this! I left a few suggestions.

@canac canac mentioned this pull request Aug 30, 2024
3 tasks
@caleballdrin caleballdrin requested a review from canac September 3, 2024 22:02
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work!

@caleballdrin caleballdrin merged commit af2818c into main Sep 4, 2024
18 checks passed
@caleballdrin caleballdrin deleted the sign-up-steps branch September 4, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants