-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPDX-8091 Preferences Setup steps UI #1002
Conversation
Bundle sizes [mpdx-react]Compared against e3e6a5a
|
Preview branch generated at https://sign-up-steps.d3dytjb8adxkk5.amplifyapp.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I think you're definitely on the right track.
pages/accountLists/[accountListId]/settings/preferences.page.tsx
Outdated
Show resolved
Hide resolved
pages/accountLists/[accountListId]/settings/preferences.page.tsx
Outdated
Show resolved
Hide resolved
pages/accountLists/[accountListId]/settings/organizations.graphql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work with this! I left a few suggestions.
pages/accountLists/[accountListId]/settings/integrations/index.page.test.tsx
Outdated
Show resolved
Hide resolved
pages/accountLists/[accountListId]/settings/integrations/index.page.test.tsx
Show resolved
Hide resolved
pages/accountLists/[accountListId]/settings/integrations/index.page.test.tsx
Outdated
Show resolved
Hide resolved
pages/accountLists/[accountListId]/settings/integrations/index.page.test.tsx
Show resolved
Hide resolved
pages/accountLists/[accountListId]/settings/integrations/index.page.tsx
Outdated
Show resolved
Hide resolved
pages/accountLists/[accountListId]/settings/preferences.page.test.tsx
Outdated
Show resolved
Hide resolved
pages/accountLists/[accountListId]/settings/preferences.page.tsx
Outdated
Show resolved
Hide resolved
src/components/Settings/preferences/GetPersonalPreferences.graphql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work!
Description
https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8091
Checklist: