-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No-Jira] Change tools links #1003
Conversation
Preview branch generated at https://tool-links.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 9803ed9
|
@dr-bizz I'm not sure why codecov failed. I haven't changed any logic. |
It is because you've moved the pages around. You will need to create a test for Maybe try that and then if that doesn't boost the score, we'll go from there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks good, just need CodeCov to pass.
@dr-bizz can you approve this? There is a PR's already for Fix Commitment info that has the test but it hasn't been merged in yet. I don't think this PR should add tests for functionality that wasn't changed in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this
Description
Change url of tools pages to the same as angular.
Checklist: