-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPDX-8088] Create setup start page #1004
Conversation
Preview branch generated at https://8088-setup-start-page.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 9c76c5c
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dr-bizz I don't disagree that there's room for improvement. Let me know if you have any specific suggestions. @j2trumpet Do you have any ideas for improving the design? I could put it in a card and/or add a blue background, but I'm at a loss besides those ideas. The Angular version looks like the screenshot in this ticket. |
Nothing jumps out at me as looking bad. Looking at the Jira ticket, it looks like this screen is all the content on the page rather than a modal appearing over other content. Are there other screens during the account/app setup process that this language screen could be styled like? |
@j2trumpet The connect organization screen looks similar (https://jira.cru.org/browse/MPDX-8089). I'll definitely make these two screens look similar. |
@dr-bizz I made the setup content a Card on a blue background. Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dr-bizz Does your comment on the other PR list the styles you changed to get that screenshot? I see you also made the button full-width. Did you change anything else?
|
I also made all the input and paragraphs in line with one another. But I think that is it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Great job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh just thought on the start pages, is it worth changing the colout of the help icon to something other than blue so it's more visible? - just a thought
a135d1a
to
970597b
Compare
Description
/setup/start
that lets the user pick their language.https://jira.cru.org/browse/MPDX-8088
Checklist: