Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPDX-8088] Create setup start page #1004

Merged
merged 4 commits into from
Aug 28, 2024
Merged

[MPDX-8088] Create setup start page #1004

merged 4 commits into from
Aug 28, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Aug 22, 2024

Description

  • Created a setup start page at /setup/start that lets the user pick their language.
  • A future PR will handle automatically detecting when the user needs to start the setup tour.
  • Added environment variables to Amplify.

https://jira.cru.org/browse/MPDX-8088

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Aug 22, 2024
@canac canac requested a review from dr-bizz August 22, 2024 21:44
Copy link
Contributor

Preview branch generated at https://8088-setup-start-page.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

github-actions bot commented Aug 22, 2024

Bundle sizes [mpdx-react]

Compared against 9c76c5c

Route Size (gzipped) Diff
/setup/start 94.55 KB added

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great! It still needs work on the design as it looks a little off compared to the rest of the design on MPDX.

Screenshot 2024-08-23 at 10 18 00 AM

src/components/Links/Links.test.tsx Outdated Show resolved Hide resolved
@canac
Copy link
Contributor Author

canac commented Aug 26, 2024

The code looks great! It still needs work on the design as it looks a little off compared to the rest of the design on MPDX.

@dr-bizz I don't disagree that there's room for improvement. Let me know if you have any specific suggestions.

@j2trumpet Do you have any ideas for improving the design? I could put it in a card and/or add a blue background, but I'm at a loss besides those ideas. The Angular version looks like the screenshot in this ticket.

@j2trumpet
Copy link
Contributor

Nothing jumps out at me as looking bad. Looking at the Jira ticket, it looks like this screen is all the content on the page rather than a modal appearing over other content. Are there other screens during the account/app setup process that this language screen could be styled like?

@canac
Copy link
Contributor Author

canac commented Aug 26, 2024

Are there other screens during the account/app setup process that this language screen could be styled like?

@j2trumpet The connect organization screen looks similar (https://jira.cru.org/browse/MPDX-8089). I'll definitely make these two screens look similar.

@canac canac requested a review from dr-bizz August 26, 2024 16:57
@canac
Copy link
Contributor Author

canac commented Aug 26, 2024

@dr-bizz I made the setup content a Card on a blue background. Let me know what you think.

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes you made, it's starting to look great. I still think there is some room for improvement.

What are your thoughts to making it like this:

Screenshot 2024-08-27 at 8 27 57 AM

@canac
Copy link
Contributor Author

canac commented Aug 27, 2024

@dr-bizz Does your comment on the other PR list the styles you changed to get that screenshot? I see you also made the button full-width. Did you change anything else?

Header text: font-size: 2.75rem
Icon colour: primary
Paragraph - max-width: 500px
Card max-width: 580px

@canac canac requested a review from dr-bizz August 27, 2024 15:48
@dr-bizz
Copy link
Contributor

dr-bizz commented Aug 27, 2024

@dr-bizz Does your comment on the other PR list the styles you changed to get that screenshot? I see you also made the button full-width. Did you change anything else?

Header text: font-size: 2.75rem
Icon colour: primary
Paragraph - max-width: 500px
Card max-width: 580px

I also made all the input and paragraphs in line with one another. But I think that is it.

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Great job

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh just thought on the start pages, is it worth changing the colout of the help icon to something other than blue so it's more visible? - just a thought

@canac
Copy link
Contributor Author

canac commented Aug 28, 2024

Oh just thought on the start pages, is it worth changing the colout of the help icon to something other than blue so it's more visible? - just a thought

Good idea. We're switching to HelpJuice pretty soon (I was working on the PR yesterday), and the HelpJuice beacon color is more different from the MPDX background color, so I'll probably leave it as-is if that's OK. And if the contrast doesn't end up being good enough, I can after that.

Screenshot 2024-08-28 at 11 02 45 AM

@canac canac force-pushed the 8088-setup-start-page branch from a135d1a to 970597b Compare August 28, 2024 18:48
@canac canac merged commit d4bcf7f into main Aug 28, 2024
18 checks passed
@canac canac deleted the 8088-setup-start-page branch August 28, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants