-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPDX 7955 add list filter functionality 2 #1006
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle sizes [mpdx-react]Compared against ed7c72e No significant changes found |
ba283ca
to
60cf5b3
Compare
d7e981b
to
ce73141
Compare
I have split this PR into 4 PRs, which have all been merged. I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the last large PR. This was created multiple weeks ago #989, but due to the PRs it was built on getting merged into main and causing tons of merge conflicts, it's easier to start fresh here. This also means I can simplify the commit history.
When testing the UI, you should be able to do everything you're able to do on the old List view on Appeals.
1. List Filters
Adding functionality to the List view's filters. Building Modals or loading in pre-made modals.
2. List Header
Ab;e to pass in page coming from to customize bulk actions and add a new action for appeals called "Add excluded contacts"
3. Appeal Header
Allow user to edit appeal name and amount details
4. Contact Row
Add action buttons to the Contact row on list, Add Excluded contact, delete contact from appeal, add,edit or delete pledge.
5. Tour
Create the tour functionality for when new appeals get created.
6. Appeal Form
Add create appeal inclusion and exclusion filters when creating new appeal.
7. Move folders
Move folders to make it easier to read.
Checklist: