Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX 7955 add list filter functionality 2 #1006

Closed
wants to merge 18 commits into from

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Aug 26, 2024

Description

This is the last large PR. This was created multiple weeks ago #989, but due to the PRs it was built on getting merged into main and causing tons of merge conflicts, it's easier to start fresh here. This also means I can simplify the commit history.

When testing the UI, you should be able to do everything you're able to do on the old List view on Appeals.

1. List Filters
Adding functionality to the List view's filters. Building Modals or loading in pre-made modals.

2. List Header
Ab;e to pass in page coming from to customize bulk actions and add a new action for appeals called "Add excluded contacts"

3. Appeal Header
Allow user to edit appeal name and amount details

4. Contact Row
Add action buttons to the Contact row on list, Add Excluded contact, delete contact from appeal, add,edit or delete pledge.

5. Tour
Create the tour functionality for when new appeals get created.

6. Appeal Form
Add create appeal inclusion and exclusion filters when creating new appeal.

7. Move folders
Move folders to make it easier to read.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

Copy link
Contributor

github-actions bot commented Aug 26, 2024

Bundle sizes [mpdx-react]

Compared against ed7c72e

No significant changes found

@dr-bizz dr-bizz force-pushed the MPDX-7955-add-list-filter-functionality-2 branch 2 times, most recently from ba283ca to 60cf5b3 Compare August 26, 2024 20:32
@dr-bizz dr-bizz force-pushed the MPDX-7955-add-list-filter-functionality-2 branch from d7e981b to ce73141 Compare August 27, 2024 20:00
@dr-bizz
Copy link
Contributor Author

dr-bizz commented Aug 29, 2024

I have split this PR into 4 PRs, which have all been merged. I will close this PR.

@dr-bizz dr-bizz closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant