Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-Jira] Update translation.json #1008

Merged
merged 3 commits into from
Aug 27, 2024
Merged

[no-Jira] Update translation.json #1008

merged 3 commits into from
Aug 27, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Aug 26, 2024

Description

  • Update en/translation.json as requested by Scott Mitchell
  • Sort en/translation{_old,}.json keys so that in the future it's easier to see which lines were added and removed.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac requested a review from dr-bizz August 26, 2024 15:29
@canac canac changed the title [no-Jira] Update translations.json [no-Jira] Update translation.json Aug 26, 2024
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 69daa04

No significant changes found

@canac canac force-pushed the update-translations branch from 03b706b to 147b435 Compare August 26, 2024 19:53
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@canac canac merged commit 3ce23f2 into main Aug 27, 2024
18 checks passed
@canac canac deleted the update-translations branch August 27, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants