Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPDX-8057 - tools sidebar #1010

Merged
merged 10 commits into from
Sep 4, 2024
Merged

MPDX-8057 - tools sidebar #1010

merged 10 commits into from
Sep 4, 2024

Conversation

wjames111
Copy link
Contributor

@wjames111 wjames111 commented Aug 27, 2024 •
edited
Loading

Description

  • Add Tools Navigation Menu to tools
  • Ticket available here

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@wjames111 wjames111 added On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview labels Aug 27, 2024
@wjames111 wjames111 self-assigned this Aug 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview branch generated at https://MPDX-8057-tools-sidebar.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against e3e6a5a

Route Size (gzipped) Diff
/accountLists/[accountListId]/tools 138.74 KB +23.78 KB
/accountLists/[accountListId]/tools/appeals 184.03 KB +2.98 KB
/accountLists/[accountListId]/tools/appeals/appeal/[[...appealId]] 214.45 KB +2.43 KB
/accountLists/[accountListId]/tools/fix/commitmentInfo/[[...contactId]] 256.29 KB +3.02 KB
/accountLists/[accountListId]/tools/fix/emailAddresses/[[...contactId]] 159.26 KB +3.05 KB
/accountLists/[accountListId]/tools/fix/mailingAddresses/[[...contactId]] 192.09 KB +3 KB
/accountLists/[accountListId]/tools/fix/phoneNumbers/[[...contactId]] 256.83 KB +3.01 KB
/accountLists/[accountListId]/tools/fix/sendNewsletter/[[...contactId]] 116.6 KB +1.53 KB
/accountLists/[accountListId]/tools/merge/contacts/[[...contactId]] 120.71 KB +1.67 KB
/accountLists/[accountListId]/tools/merge/people/[[...contactId]] 120.06 KB +1.68 KB

@wjames111 wjames111 requested a review from canac September 3, 2024 13:58
canac
canac requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! You should just need a few more tests, and I left some refactoring suggestions too.

pages/accountLists/[accountListId]/tools/ToolsWrapper.tsx Outdated Show resolved Hide resolved
src/components/Tool/NavToolList/Item/Item.tsx Outdated Show resolved Hide resolved
src/components/Tool/NavToolList/Item/Item.test.tsx Outdated Show resolved Hide resolved
src/components/Tool/NavToolList/Item/Item.test.tsx Show resolved Hide resolved
src/components/Tool/NavToolList/NavToolList.tsx Outdated Show resolved Hide resolved
src/components/Tool/NavToolList/NavToolList.tsx Outdated Show resolved Hide resolved
src/components/Tool/NavToolList/Item/Item.tsx Show resolved Hide resolved
src/components/Tool/NavToolList/NavToolList.test.tsx Show resolved Hide resolved
src/components/Tool/NavToolList/NavToolList.tsx Outdated Show resolved Hide resolved
src/components/Tool/NavToolList/NavToolList.tsx Outdated Show resolved Hide resolved
canac
canac approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two small requests, but I'm going to go ahead and approve. You can merge after you address them. Thanks for working on this!

src/components/Tool/NavToolList/Item/Item.test.tsx Outdated Show resolved Hide resolved
src/components/Tool/NavToolList/NavToolList.test.tsx Show resolved Hide resolved
@wjames111 wjames111 force-pushed the MPDX-8057-tools-sidebar branch from 1fff312 to e08c137 Compare September 4, 2024 16:07
@wjames111
Copy link
Contributor Author

@canac Awesome thanks for all your help with this!

@wjames111 wjames111 merged commit 7760bad into main Sep 4, 2024
17 of 18 checks passed
@wjames111 wjames111 deleted the MPDX-8057-tools-sidebar branch September 4, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canac canac canac approved these changes

Assignees

@wjames111 wjames111

Labels
On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjames111 @canac