-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appeal list contact row functionality #1013
Conversation
Bundle sizes [mpdx-react]Compared against 5c1f773
|
If |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it thoroughly yet but here's my comments so far.
@canac I can't see you comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Just some minor suggestions.
src/components/Layouts/Primary/TopBar/Items/AddMenu/Items/AddDonation/AddDonation.tsx
Outdated
Show resolved
Hide resolved
src/components/Tool/Appeal/Modals/DeletePledgeModal/DeletePledgeModal.tsx
Outdated
Show resolved
Hide resolved
e96beb3
to
b88d799
Compare
const amount = donation?.appealAmount?.amount; | ||
const currency = donation?.appealAmount?.convertedCurrency; | ||
let donationAmount = ''; | ||
if (amount && currency) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize what you were trying to accomplish was so simple. I thought there was a branch where you needed to render the raw amount without calling currency format. Thanks for making the logic verbose and clear! If you wanted to simplify, you could do const donationAmount = currencyFormat(amount && currency ? amount : 0, currency, locale);
1aee532
to
3600e13
Compare
Description
In this PR, I added functionality to the contact row. Allow the user to add a pledge, edit a pledge, delete a pledge, remove a contact from an appeal and add an excluded contact.
You will see I added some files from the commit
[1. List Filters - Add contacts to appeal](https://github.com/CruGlobal/mpdx-react/commit/c2412ee8379da48151c5e0cdfc13e81d0862fd3c)
otherwise this PR would break. This should be merged in before this merges so I will remove that once that happens.Changes
Checklist: