Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8130 - Add Remove commitment warning on the Edit Partnership modal #1015

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Aug 28, 2024

Description

In this PR, I added a warning message on the edit partnership modal that only shows when a contact is switched from the "Partner - Financial" status to another, and either the committed amount or committed frequency or both are filled out.

The user is presented with two options. Yes, clear the amount and frequency, or No, leave them as they are.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

…al" to another status is commitment or frequency is set.
@dr-bizz dr-bizz requested a review from canac August 28, 2024 13:33
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 3ce23f2

No significant changes found

Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work adding this! 🔥

@dr-bizz dr-bizz merged commit 9c76c5c into main Aug 28, 2024
17 checks passed
@dr-bizz dr-bizz deleted the commitment-removal-warning branch August 28, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants