Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPDX-7894] Migrate from HelpScout beacon to Helpjuice beacon #1019

Merged
merged 13 commits into from
Sep 26, 2024
Merged

[MPDX-7894] Migrate from HelpScout beacon to Helpjuice beacon #1019

merged 13 commits into from
Sep 26, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Aug 29, 2024 •
edited
Loading

Description

  • Remove HelpScout beacon
  • Add Helpjuice beacon
  • Customize the contact link to send information about the current user and the current URL to Helpjuice
  • Added HELPJUICE_ORIGIN, HELPJUICE_KNOWLEDGE_BASE_URL, and HELP_URL_* environment variables to Amplify

Supersedes #942

MPDX-7894

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Aug 29, 2024
@canac canac requested a review from dr-bizz August 29, 2024 18:32
@github-actions GitHub Actions
Copy link
Contributor

Preview branch generated at https://7894-helpjuice-beacon.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 29, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against ab8caaf

No significant changes found

dr-bizz
dr-bizz requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I think we are losing a lot of functionailty with losing suggested contacts. where we had suggested contacts before maybe we can link to the HelpDucks article?

pages/_app.page.tsx Outdated Show resolved Hide resolved
src/components/Coaching/CoachingDetail/AppointmentResults/AppointmentResults.tsx Show resolved Hide resolved
@canac canac force-pushed the 7894-helpjuice-beacon branch from efe4697 to 89663ff Compare September 6, 2024 19:00
@canac canac requested a review from dr-bizz September 6, 2024 20:38
dr-bizz
dr-bizz reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is looking great. I have a few questions but apart from that it looks complete. 🔥

pages/_app.page.tsx Outdated Show resolved Hide resolved
pages/_document.page.tsx Show resolved Hide resolved
pages/_document.page.tsx Show resolved Hide resolved
pages/_document.page.tsx Show resolved Hide resolved
src/components/Coaching/CoachingDetail/HelpButton.tsx Outdated Show resolved Hide resolved
@canac canac requested a review from dr-bizz September 10, 2024 15:55
dr-bizz
dr-bizz approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great. I added a comment here #1019 (comment)

But I'll approve this.

@canac canac force-pushed the 7894-helpjuice-beacon branch from c3b70dc to 8849af5 Compare September 10, 2024 18:44
@canac canac force-pushed the 7894-helpjuice-beacon branch from 8849af5 to 837231b Compare September 13, 2024 17:30
@canac
Adjust Helpjuice widget height on short screens
fa7481c 
Also, move the Helpjuice widget closer to the bottom of the page when it
is expanded to give more space for the widget content.
@canac canac self-assigned this Sep 20, 2024
@canac canac merged commit e4cb967 into main Sep 26, 2024
17 of 18 checks passed
@canac canac deleted the 7894-helpjuice-beacon branch September 26, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

Assignees

@canac canac

Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canac @dr-bizz