MPDX-8123 & MPDX-8125 Add Pledges, Commitments and donations flows view #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle sizes [mpdx-react]Compared against c09143f
|
|
When you delete a commitment, the edit/delete buttons are still there in the flows view. Then if you click edit, I get an error message about the pledge not being found. Is that a bug you want to fix in this PR? Screen.Recording.2024-08-30.at.9.51.43.AM.mov |
canac
requested changes
Aug 30, 2024
src/components/Tool/Appeal/Flow/ContactFlowRow/ContactFlowRow.test.tsx
Outdated
Show resolved
Hide resolved
src/components/Tool/Appeal/Shared/AmountAndFrequency/AmountAndFrequency.tsx
Outdated
Show resolved
Hide resolved
This fix deserves its own PR. |
|
Added it as a task here- MPDX-8137 |
canac
approved these changes
Aug 30, 2024
… useMemo and Making hook take one object instead of 3 arguments
dr-bizz
force-pushed
the
MPDX-8123-MPDX-8125-pledges-commitments-and-donations-flows-view
branch
from
72e9bc3 to
aad2fc4
Compare
dr-bizz
deleted the
MPDX-8123-MPDX-8125-pledges-commitments-and-donations-flows-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces enhancements to the flows view by adding support for pledges, commitments, and donations. The changes include cleaning up the flows view and centralizing logic into a reusable hook.
Changes
ContactFlowRowcomponentContactRowpledges functionality into a custom hook used in both the list and flows view.contactFlowsRowcomponent and hook.Please explain a bullet-point summary of the changes.
List any PRs that this PR is dependent on and any Jira tickets that this PR is related to.
Checklist: