-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPDX-8087] Take the user through the tour if their account isn't set up #1029
Conversation
Preview branch generated at https://8087-setup-redirect.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 4fdfe9b No significant changes found |
cf009b5
to
c844892
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few questions but it looks great.
@caleballdrin Do you have capacity to address that?
@dr-bizz Correct. That will be done in MPDX-8095. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we spoke about adding the feature-flag with an environment variable. But as I don't want to block you, I will approve this PR.
c77ba6f
to
7fe9910
Compare
It will redirect the user to the setup pages if they need to set up their account.
7fe9910
to
e562f4a
Compare
Description
settingUp
context to the entire application. It will be used in a future PR to hide navbar links when in setup mode.MPDX-8087
Checklist: