Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPDX-8087] Take the user through the tour if their account isn't set up #1029

Merged
merged 9 commits into from
Sep 6, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Sep 4, 2024

Description

  • On the account's list page, do a server-side redirect to force the user to take the tour if their account isn't set up.
  • On every page, do a client-side redirect to force the user to take the tour if their account isn't set up.
  • Provide settingUp context to the entire application. It will be used in a future PR to hide navbar links when in setup mode.

MPDX-8087

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Sep 4, 2024
@canac canac requested a review from caleballdrin September 4, 2024 22:05
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Preview branch generated at https://8087-setup-redirect.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Bundle sizes [mpdx-react]

Compared against 4fdfe9b

No significant changes found

@canac canac force-pushed the 8087-setup-redirect branch from cf009b5 to c844892 Compare September 5, 2024 15:33
@canac canac requested a review from dr-bizz September 5, 2024 15:38
@caleballdrin caleballdrin self-requested a review September 5, 2024 16:34
Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few questions but it looks great.

src/components/Setup/useNextSetupPage.ts Outdated Show resolved Hide resolved
src/components/Setup/SetupProvider.tsx Outdated Show resolved Hide resolved
pages/accountLists.page.tsx Outdated Show resolved Hide resolved
@dr-bizz
Copy link
Contributor

dr-bizz commented Sep 5, 2024

I know this isn't apart of this PR, but on the old setup notifications, we didn't have a skip button.
Also, it looks like the Tools pages tour isn't showing. this might because it is yet to be built

Screenshot 2024-09-05 at 3 22 42 PM

@canac
Copy link
Contributor Author

canac commented Sep 5, 2024

I know this isn't apart of this PR, but on the old setup notifications, we didn't have a skip button.

@caleballdrin Do you have capacity to address that?

Also, it looks like the Tools pages tour isn't showing. this might because it is yet to be built

@dr-bizz Correct. That will be done in MPDX-8095.

@canac canac requested a review from dr-bizz September 5, 2024 20:12
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we spoke about adding the feature-flag with an environment variable. But as I don't want to block you, I will approve this PR.

@canac canac force-pushed the 8087-setup-redirect branch from c77ba6f to 7fe9910 Compare September 6, 2024 14:57
@canac canac force-pushed the 8087-setup-redirect branch from 7fe9910 to e562f4a Compare September 6, 2024 16:05
@canac canac enabled auto-merge September 6, 2024 16:05
@canac canac merged commit a12791c into main Sep 6, 2024
18 checks passed
@canac canac deleted the 8087-setup-redirect branch September 6, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants