Removes duplicate headers for all tools. #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjames111
added
On Staging
|
Preview branch generated at https://MPDX-0000-tools-remove-duplicate-header.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against d4ae9c2 No significant changes found |
caleballdrin
reviewed
Sep 9, 2024
| @@ -152,11 +152,6 @@ const FixSendNewsletter: React.FC<Props> = ({ | |||
| return ( | |||
| <Box className={classes.outer} data-testid="Home"> | |||
| <Grid container className={classes.container}> | |||
| <Grid item xs={12}> | |||
| <Typography variant="h4">{t('Fix Send Newsletter')}</Typography> | |||
| <Divider className={classes.divider} /> | |||
There was a problem hiding this comment.
Could you also remove the classes.divider styles if they aren't being used?
caleballdrin
reviewed
Sep 9, 2024
| @@ -121,10 +115,6 @@ const MergeContacts: React.FC<Props> = ({ | |||
| > | |||
| {!loading && data ? ( | |||
| <Grid container className={classes.container}> | |||
| <Grid item xs={12}> | |||
| <Typography variant="h4">{t('Merge Contacts')}</Typography> | |||
| <Divider className={classes.divider} /> | |||
There was a problem hiding this comment.
Remove divider styles here as well.
caleballdrin
reviewed
Sep 9, 2024
| @@ -123,10 +117,7 @@ const MergePeople: React.FC<Props> = ({ | |||
| > | |||
| {!loading && data ? ( | |||
| <Grid container className={classes.container}> | |||
| <Grid item xs={12}> | |||
| <Typography variant="h4">{t('Merge People')}</Typography> | |||
| <Divider className={classes.divider} /> | |||
caleballdrin
reviewed
Sep 9, 2024
| @@ -207,10 +206,6 @@ const TntConnect: React.FC<Props> = ({ accountListId }: Props) => { | |||
| <LoadingSpinner firstLoad={true} data-testid="LoadingSpinner" /> | |||
| )} | |||
| <ContainerBox container> | |||
| <Grid item xs={12}> | |||
| <Typography variant="h4">{t('Import from TntConnect')}</Typography> | |||
| <Divider className={classes.divider} /> | |||
caleballdrin
approved these changes
Sep 9, 2024
|
@caleballdrin Thanks! Sorry I should have removed those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist: