Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8156 - Tools - Fix Commitment Info - console errors #1042

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

wjames111
Copy link
Contributor

@wjames111 wjames111 commented Sep 9, 2024

Description

  • Console error, out of range value provided for field.
  • Console error: Failed prop type: The prop lg of Grid can only be used together with the item prop
  • Jira Ticket 8156 and 8177

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@wjames111 wjames111 added On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview labels Sep 9, 2024
@wjames111 wjames111 self-assigned this Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Bundle sizes [mpdx-react]

Compared against b118740

No significant changes found

@wjames111 wjames111 force-pushed the MPDX-8156-tools-fix-commitment-info-console-errors branch from ba2ce2f to 9cafc06 Compare September 23, 2024 18:01
@wjames111 wjames111 force-pushed the MPDX-8156-tools-fix-commitment-info-console-errors branch from 71ea4bb to 8a76903 Compare September 23, 2024 20:31
Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wjames111 wjames111 merged commit 0f988fa into main Sep 23, 2024
17 of 18 checks passed
@wjames111 wjames111 deleted the MPDX-8156-tools-fix-commitment-info-console-errors branch September 23, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants