Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPDX-8220 Donation Designation #1067

Merged
merged 5 commits into from
Sep 16, 2024
Merged

MPDX-8220 Donation Designation #1067

merged 5 commits into from
Sep 16, 2024

Conversation

caleballdrin
Copy link
Contributor

Description

https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8220&sprint=1259#
https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8222&sprint=1259#

  • Check if designation name doesn't exist, then use the designationNumber

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin self-assigned this Sep 13, 2024
@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Sep 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview branch generated at https://MPDX-8220-donation-designation.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 13, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against 833d6e5

No significant changes found

dr-bizz
dr-bizz requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! I left some comments but most are just stylistic changes

src/components/DonationTable/DonationTable.tsx Outdated Show resolved Hide resolved
src/components/EditDonationModal/EditDonationModal.graphql Show resolved Hide resolved
src/components/EditDonationModal/EditDonationModal.tsx Outdated Show resolved Hide resolved
src/components/Shared/MultiPageLayout/MultiPageMenu/MultiPageMenu.tsx Outdated Show resolved Hide resolved
dr-bizz
dr-bizz approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on this!! 🔥🔥‍🚒

@caleballdrin caleballdrin merged commit 67614f0 into main Sep 16, 2024
18 checks passed
@caleballdrin caleballdrin deleted the MPDX-8220-donation-designation branch September 16, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

Assignees

@caleballdrin caleballdrin

Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caleballdrin @dr-bizz