Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mpdx 8159 fix email addresses style updates #1069

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Mpdx 8159 fix email addresses style updates #1069

merged 4 commits into from
Sep 16, 2024

Conversation

wjames111
Copy link
Contributor

Description

  • Style updates to Fix Email Addreses
  • Ticket number 8131 MPDX-8131

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@wjames111 wjames111 added On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview labels Sep 13, 2024
@wjames111 wjames111 self-assigned this Sep 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview branch generated at https://MPDX-8159-fix-email-addresses-style-updates.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 13, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against 1e71312

Route Size (gzipped) Diff
/accountLists/[accountListId]/tools/fix/emailAddresses/[[...contactId]] 166.35 KB +5 KB

caleballdrin
caleballdrin approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! It looks way better. I just had a few small changes.

@wjames111 wjames111 merged commit a2d81f8 into main Sep 16, 2024
17 of 18 checks passed
@wjames111 wjames111 deleted the MPDX-8159-fix-email-addresses-style-updates branch September 16, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleballdrin caleballdrin caleballdrin approved these changes

Assignees

@wjames111 wjames111

Labels
On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjames111 @caleballdrin