Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPDX-8226 Edit Partnership Info & Contact Header #1081

Merged
merged 9 commits into from
Sep 19, 2024
Merged

MPDX-8226 Edit Partnership Info & Contact Header #1081

merged 9 commits into from
Sep 19, 2024

Conversation

caleballdrin
Copy link
Contributor

@caleballdrin caleballdrin commented Sep 19, 2024 •
edited
Loading

Description

https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8226&sprint=1259#

Contact Header

  • Improve styles
  • Remove Partnership Account Number
  • Make Contact close icon bigger
  • Make links only underlined on hover

Contact Details

  • Move Greeting and Envelope Name to 'Other' section
  • Rename Mailing to Addresses
  • Fix Person Name showing 'null'
  • Fix address having comma if no address
  • Move 'Add Person' and 'Add Address' buttons
  • Improve addresses spacing

Modals

  • Consolidate edit modals so it is easier to find what you want to edit
  • Move Contact Name and Primary Contact to the Edit Partnership Info Modal
  • Move Greeting and Envelope Name to the ContactOtherModal
    -Improve spacing of form fields in the modals

Other

  • Update titles of icons
  • Make Task Tab content taller so it is easier to see tasks

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin self-assigned this Sep 19, 2024
@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Sep 19, 2024
@caleballdrin caleballdrin requested a review from canac September 19, 2024 16:53
@github-actions GitHub Actions
Copy link
Contributor

Preview branch generated at https://MPDX-8226-edit-partnership-info.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against d6e415c

Route Size (gzipped) Diff
/accountLists/[accountListId]/tools/fix/commitmentInfo/[[...contactId]] 248.61 KB -9.3 KB
/accountLists/[accountListId]/tools/fix/phoneNumbers/[[...contactId]] 249.08 KB -9.31 KB
Dynamic import Size (gzipped) Diff
../src/components/Contacts/ContactDetails/ContactDetailsTab/DynamicContactDetailsTab.tsx -> ./ContactDetailsTab 75.25 KB +8.54 KB
../src/components/Contacts/ContactDetails/ContactDonationsTab/DynamicContactDonationsTab.tsx -> ./ContactDonationsTab 190.12 KB +7.92 KB
../src/components/Contacts/ContactsRightPanel/DynamicContactsRightPanel.tsx -> ./ContactsRightPanel 132.22 KB -9.32 KB

canac
canac reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! You've made a lot of little changes that add up to make this a lot better!

src/components/common/StarredItemIcon/StarredItemIcon.tsx Outdated Show resolved Hide resolved
src/components/Contacts/ContactDetails/ContactDetailsHeader/ContactDetailsHeader.tsx Outdated Show resolved Hide resolved
src/components/Contacts/ContactDetails/ContactDetailsHeader/ContactDetailsHeader.tsx Show resolved Hide resolved
...cts/ContactDetails/ContactDetailsHeader/ContactHeaderSection/ContactHeaderAddressSection.tsx Outdated Show resolved Hide resolved
...Contacts/ContactDetails/ContactDetailsTab/People/Items/PersonModal/PersonName/PersonName.tsx Outdated Show resolved Hide resolved
src/lib/data/languages.ts Outdated Show resolved Hide resolved
...tacts/ContactDetails/ContactDetailsTab/Other/EditContactOtherModal/EditContactOtherModal.tsx Outdated Show resolved Hide resolved
...tacts/ContactDetails/ContactDetailsTab/Other/EditContactOtherModal/EditContactOtherModal.tsx Show resolved Hide resolved
...ls/ContactDonationsTab/PartnershipInfo/EditPartnershipInfoModal/EditPartnershipInfoModal.tsx Outdated Show resolved Hide resolved
src/components/Contacts/ContactDetails/ContactDetailsTab/ContactDetailsTab.tsx Show resolved Hide resolved
@caleballdrin caleballdrin requested a review from canac September 19, 2024 21:02
canac
canac approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just localize the titleAccess strings, and this is good to go!

src/components/common/StarredItemIcon/StarredItemIcon.tsx Outdated
Comment on lines 24 to 26
<StarFilled titleAccess="Unstar" data-testid="Filled Star Icon" />
) : (
<StarOutline titleAccess="Star" data-testid="Outline Star Icon" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized that these and the other titleAccesses should probably be localized.

@caleballdrin caleballdrin merged commit e584ed2 into main Sep 19, 2024
18 checks passed
@caleballdrin caleballdrin deleted the MPDX-8226-edit-partnership-info branch September 19, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canac canac canac approved these changes

Assignees

@caleballdrin caleballdrin

Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caleballdrin @canac