Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPDX-8229] Add duplicate contact button #1083

Merged
merged 4 commits into from
Sep 20, 2024
Merged

[MPDX-8229] Add duplicate contact button #1083

merged 4 commits into from
Sep 20, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Sep 19, 2024

Description

  • When a contact has an unignored duplicate, show a button that that will take them to the merge contacts tools page.

@wrandall22 I'm going to let Caleb A review this one for you if you're good with that.

MPDX-8229

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Sep 19, 2024
@canac canac requested a review from caleballdrin September 19, 2024 21:56
@canac canac self-assigned this Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview branch generated at https://8229-duplicate-contact-message.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against e584ed2

No significant changes found

@canac canac requested a review from wrandall22 September 20, 2024 11:50
@caleballdrin caleballdrin self-requested a review September 20, 2024 14:46
caleballdrin
caleballdrin approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. It was more involved than I thought. Nice work making the Merge contacts page have only the one contact on it.

@canac canac merged commit a8a2f6e into main Sep 20, 2024
18 checks passed
@canac canac deleted the 8229-duplicate-contact-message branch September 20, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleballdrin caleballdrin caleballdrin approved these changes

@wrandall22 wrandall22 Awaiting requested review from wrandall22

Assignees

@canac canac

Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canac @caleballdrin