Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPDX-8237 - Shows tasks count, updates Tasks once deleted. #1088

Merged
merged 12 commits into from
Sep 26, 2024
Merged

MPDX-8237 - Shows tasks count, updates Tasks once deleted. #1088

merged 12 commits into from
Sep 26, 2024

Conversation

wjames111
Copy link
Contributor

@wjames111 wjames111 commented Sep 23, 2024 •
edited
Loading

Ticket

Description

  • Show total count on Tasks like Angular version
  • Update total count when single task is deleted

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@wjames111 wjames111 added On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview labels Sep 23, 2024
@wjames111 wjames111 self-assigned this Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview branch generated at https://MPDX-8237-tasks-delete-task-count.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against e4cb967

No significant changes found

caleballdrin
caleballdrin previously requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@caleballdrin caleballdrin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great so far. We just need to fix the count when using the Delete icon button.

@caleballdrin caleballdrin requested a review from canac September 24, 2024 19:45
canac
canac reviewed Sep 24, 2024
View reviewed changes
src/components/Shared/Header/ListHeader.test.tsx Outdated Show resolved Hide resolved
src/hooks/useMassSelection.ts Outdated Show resolved Hide resolved
@wjames111 wjames111 requested a review from canac September 26, 2024 20:25
canac
canac approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be working well!

pages/accountLists/[accountListId]/tasks/Tasks.test.tsx
);
await waitFor(() => expect(getByText('Test Person')).toBeInTheDocument());
expect(getByTestId('task-checkbox-1')).toBeInTheDocument();
userEvent.click(getByTestId('task-checkbox-1'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're clicking this checkbox, you don't also have to check that it's in the document.

pages/accountLists/[accountListId]/tasks/Tasks.test.tsx Show resolved Hide resolved
@wjames111 wjames111 dismissed caleballdrin’s stale review September 26, 2024 21:36

I think we got everything!

@wjames111 wjames111 merged commit 25bf185 into main Sep 26, 2024
17 of 18 checks passed
@wjames111 wjames111 deleted the MPDX-8237-tasks-delete-task-count branch September 26, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canac canac canac approved these changes

@caleballdrin caleballdrin Awaiting requested review from caleballdrin

Assignees

@wjames111 wjames111

Labels
On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wjames111 @canac @caleballdrin