Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8257 Create-appeal-contacts #1093

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

caleballdrin
Copy link
Contributor

Description

https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8257&sprint=1268#

  • Replace hard coded and graphql contact statuses with ones from useContactPartnershipStatuses() hook
  • Fix tests

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin self-assigned this Sep 24, 2024
@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Sep 24, 2024
Copy link
Contributor

Copy link
Contributor

github-actions bot commented Sep 24, 2024

Bundle sizes [mpdx-react]

Compared against 1d69035

Route Size (gzipped) Diff
/_app 373.46 KB +1.8 KB
/accountLists 119.31 KB -1.2 KB
/accountLists/[accountListId] 271.03 KB -1022 B
/accountLists/[accountListId]/coaching/[coachingId] 247.81 KB +1.57 KB
/accountLists/[accountListId]/contacts/flows/setup 180.39 KB +32.57 KB
/accountLists/[accountListId]/reports/coaching 247.82 KB +1.57 KB
/accountLists/[accountListId]/reports/donations/[[...contactId]] 344.59 KB -1.99 KB
/accountLists/[accountListId]/reports/expectedMonthlyTotal 110.36 KB +1.69 KB
/accountLists/[accountListId]/settings/integrations 161.77 KB -2 KB
/accountLists/[accountListId]/settings/manageAccounts 142.42 KB -1.98 KB
/accountLists/[accountListId]/settings/manageCoaches 138.97 KB -1.21 KB
/accountLists/[accountListId]/settings/organizations 136.67 KB -1.07 KB
/accountLists/[accountListId]/settings/preferences 212.41 KB -1.04 KB
/accountLists/[accountListId]/tasks/[[...contactId]] 140.77 KB +3 KB
/accountLists/[accountListId]/tools 142.3 KB -1.13 KB
/accountLists/[accountListId]/tools/fix/commitmentInfo/[[...contactId]] 249.67 KB +1.27 KB
/accountLists/[accountListId]/tools/fix/sendNewsletter/[[...contactId]] 117.37 KB -1.21 KB
/accountLists/[accountListId]/tools/import/csv 106.9 KB -1.21 KB
/accountLists/[accountListId]/tools/import/google 156.32 KB -2.31 KB
/accountLists/[accountListId]/tools/import/tnt 149.97 KB -2.85 KB
/login 119.37 KB -1.02 KB
Dynamic import Size (gzipped) Diff
../src/components/Contacts/ContactFlow/DynamicContactFlow.tsx -> ./ContactFlow 67.21 KB +6.11 KB
../src/components/Contacts/ContactsList/DynamicContactsList.tsx -> ./ContactsList 44.76 KB +1.86 KB
../src/components/Contacts/ContactsMap/DynamicContactsMap.tsx -> ./ContactsMap 32.38 KB +1.63 KB
../src/components/Contacts/ContactsMap/DynamicContactsMapPanel.tsx -> ./ContactsMapPanel 8.05 KB +1.8 KB
../src/components/Contacts/ContactsRightPanel/DynamicContactsRightPanel.tsx -> ./ContactsRightPanel 133.43 KB +1.38 KB
../src/components/Contacts/MassActions/Exports/Emails/DynamicMassActionsExportEmailsModal.tsx -> ./MassActionsExportEmailsModal 2.08 KB -1.02 KB
../src/components/Dashboard/ThisWeek/NewsletterMenu/MenuItems/LogNewsLetter/DynamicLogNewsletter.tsx -> ./LogNewsletter 89.88 KB -1.06 KB
../src/components/Dashboard/ThisWeek/WeeklyActivity/WeeklyReportModal/DynamicWeeklyReportModal.tsx -> ./WeeklyReportModal 33.15 KB -1.39 KB
../src/components/EditDonationModal/DynamicEditDonationModal.tsx -> ./EditDonationModal 76.23 KB +2.1 KB
../src/components/Layouts/Primary/TopBar/Items/AddMenu/Items/CreateMultipleContacts/DynamicCreateMultipleContacts.tsx -> ./CreateMultipleContacts 76.62 KB +1.49 KB
../src/components/Task/Modal/Form/Complete/DynamicTaskModalCompleteForm.tsx -> ./TaskModalCompleteForm 111.13 KB +12.47 KB
../src/components/Task/Modal/Form/DynamicTaskModalForm.tsx -> ./TaskModalForm 120.98 KB +14.43 KB
../src/components/Task/Modal/Form/LogForm/DynamicTaskModalLogForm.tsx -> ./TaskModalLogForm 149.71 KB +9.58 KB
../src/components/Tool/Appeal/Flow/DynamicContactFlow.tsx -> ./ContactFlow 67.21 KB +6.11 KB
../src/components/Tool/Appeal/List/ContactsList/DynamicContactsList.tsx -> ./ContactsList 44.76 KB +1.86 KB
../src/components/Tool/Appeal/Modals/PledgeModal/DynamicPledgeModal.tsx -> ./PledgeModal 74.04 KB -1.03 KB
../src/components/Tool/Appeal/Modals/UpdateDonationsModal/DynamicUpdateDonationsModal.tsx -> ./UpdateDonationsModal 103.91 KB -1.58 KB

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! I left some comments, but I will approve this to prevent blocking you

FYI, Previews will not work on Task Phases PRs since the previews use the production API.

@caleballdrin caleballdrin merged commit 16b8c76 into MPDX-task-phases-new Sep 26, 2024
15 of 16 checks passed
@caleballdrin caleballdrin deleted the MPDX-8257-create-appeal-contacts branch September 26, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants