-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPDX-8274 Update hard-coded domains #1097
Conversation
Bundle sizes [mpdx-react]Compared against 6d59eab No significant changes found |
… login screen on React MPDX. - I am checking with the Okta team this is the case after we switch
Requesting Bill instead of Caleb C as I know ow he's stressed to get the flows work complete. |
Once you have reviewed this PR, please review this PR #1098, which I will roll live after we switch MPDX. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few questions
… to non-cru orgs
MPDX-8274 Pointing GH CI to use new domain after we switch react MPDX to production
When it comes time Squash and merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Description
MPDX-8274 & MPDX-8271
In this PR, I update any place we have the domain
next.mpdx.org
and switch it tompdx.org
.There weren't many env vars default values to update. I updated a lot of test files and the ReadMe file.
On nextAuth, I switched the
fromURI
to return tompdx.org/login
. This should be okay as the React MPDX domain will be mpdx.org. But I am also checking with the Okta team to confirm we should be all good and there isn't a setting I need to set on the Okta application for React.Checklist: