Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8274 Update hard-coded domains #1097

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Sep 26, 2024

Description

MPDX-8274 & MPDX-8271
In this PR, I update any place we have the domain next.mpdx.org and switch it to mpdx.org.

There weren't many env vars default values to update. I updated a lot of test files and the ReadMe file.

On nextAuth, I switched the fromURI to return to mpdx.org/login. This should be okay as the React MPDX domain will be mpdx.org. But I am also checking with the Okta team to confirm we should be all good and there isn't a setting I need to set on the Okta application for React.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tvdeyen Thomas von Deyen
Copy link
Contributor

github-actions bot commented Sep 26, 2024

Bundle sizes [mpdx-react]

Compared against 6d59eab

No significant changes found

… login screen on React MPDX. - I am checking with the Okta team this is the case after we switch
@dr-bizz dr-bizz requested review from canac and wrandall22 and removed request for canac September 26, 2024 14:38
@dr-bizz
Copy link
Contributor Author

dr-bizz commented Sep 26, 2024

Requesting Bill instead of Caleb C as I know ow he's stressed to get the flows work complete.

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Sep 26, 2024

Once you have reviewed this PR, please review this PR #1098, which I will roll live after we switch MPDX.

Copy link
Contributor

@wrandall22 wrandall22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions

README.md Outdated Show resolved Hide resolved
next.config.js Show resolved Hide resolved
pages/api/auth/[...nextauth].page.ts Outdated Show resolved Hide resolved
… to non-cru orgs
@dr-bizz dr-bizz requested a review from wrandall22 September 26, 2024 18:34
MPDX-8274 Pointing GH CI to use new domain after we switch react MPDX to production
@dr-bizz
Copy link
Contributor Author

dr-bizz commented Sep 26, 2024

When it comes time Squash and merge this PR.

Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@dr-bizz dr-bizz merged commit 283ba6a into main Oct 2, 2024
18 checks passed
@dr-bizz dr-bizz deleted the MPDX-8274-update-env-vars branch October 2, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants