[MPDX-8270] Remove handoff links #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview branch generated at https://8270-remove-handoff-links.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 0f716c5 No significant changes found |
dr-bizz
reviewed
Sep 27, 2024
Comment on lines
+112
to
+121
|
|
||
| {/* {hasFinancial && ( | ||
| <Box display="flex"> | ||
| <HandoffLink | ||
| path={`/reports/financial_accounts/${account.id}`} | ||
| > | ||
| <Link>Summary</Link> | ||
| </HandoffLink> | ||
| // Used to link to be a handoff link to /reports/financial_accounts/${account.id} | ||
| <Link>Summary</Link> | ||
| {' · '} | ||
| <HandoffLink | ||
| path={`/reports/financial_accounts/${account.id}/entries`} | ||
| > | ||
| <Link>Transactions</Link> | ||
| </HandoffLink> | ||
| // Used to link to be a handoff link to /reports/financial_accounts/${account.id}/entries | ||
| <Link>Transactions</Link> | ||
| </Box> | ||
| )} | ||
| )} */} |
There was a problem hiding this comment.
We are building this. It might be worth to add a notice here to say "Summary and Transactions are coming in the next few days."
dr-bizz
approved these changes
Sep 27, 2024
canac
commented
Sep 27, 2024
src/components/Settings/preferences/accordions/EarlyAdopterAccordion/EarlyAdopterAccordion.tsx
Outdated
Show resolved
Hide resolved
Also, remove userId from UserPreferenceProvider since it is no longer used.
canac
force-pushed
the
8270-remove-handoff-links
branch
from
e72db3e to
043e697
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<HandoffLink><OauthLink>component that is a simplified version ofHandoffLinkspecifically for oauth links/api/stop-impersonationrouteMPDX-8270
Checklist: