Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPDX-8330] Fix Google Calendar integration activity type checkboxes #1110

Merged
merged 8 commits into from
Oct 3, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Oct 2, 2024

Description

The Google Calendar integration activity type checkboxes were using the translated names. This PR switches them to use ActivityTypeEnum values. This PR also contains some general cleanup and improvements to EditGoogleIntegrationForm.

MPDX-8330

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Oct 2, 2024
@canac canac requested a review from dr-bizz October 2, 2024 20:56
@canac canac self-assigned this Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Bundle sizes [mpdx-react]

Compared against 6cb1fb2

No significant changes found

@canac canac force-pushed the 8330-google-integration-checkboxes branch from 096ada3 to 4d4ffd9 Compare October 2, 2024 21:04
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for improving that page.

@canac canac merged commit 4599640 into main Oct 3, 2024
18 checks passed
@canac canac deleted the 8330-google-integration-checkboxes branch October 3, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants