Coaching Page - Add person's name #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleballdrin
added
the
Preview Environment
|
Preview branch generated at https://helpscout-coaching-name.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against e9331a0
|
canac
reviewed
Oct 4, 2024
There was a problem hiding this comment.
Great work! A couple small fixes and this will be ready to go. Can you add a test too that the users are shown?
You can check off the "Missing second name for coached user" line from our functionality review sheet when this merges, because I'm pretty sure it's a duplicate.
canac
approved these changes
Oct 4, 2024
canac
reviewed
Oct 4, 2024
| }); | ||
| }); | ||
|
|
||
| expect(await findByText('Initiate for Appointment')).toBeInTheDocument(); | ||
| await waitFor( |
There was a problem hiding this comment.
You can also customize findByText's timeout if you need to: findByText('...', {}, { timeout: 3000 }).
There was a problem hiding this comment.
Ah ok good to know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://secure.helpscout.net/conversation/2724265010/1237546?folderId=7669074
Checklist: