[MPDX-8340] Fix appeal mass selection logic #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove extra redundante state and input and calculate the total and state based on the input ids and selected ids.
|
Preview branch generated at https://8340-appeals-select-contacts.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 94a3ffc No significant changes found |
dr-bizz
reviewed
Oct 7, 2024
dr-bizz
approved these changes
Oct 7, 2024
|
Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were various mass-selection bugs, especially in appeals flows view. This PR makes the mass selection logic much more robust and ensures that the total count and checkbox state is perfectly in sync with the selected ids.
MPDX-8340
Checklist: