Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPDX-8363] Fix flaky suggested contact status tests #1119

Merged
merged 5 commits into from
Oct 8, 2024
Merged

[MPDX-8363] Fix flaky suggested contact status tests #1119

merged 5 commits into from
Oct 8, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Oct 7, 2024 •
edited
Loading

Description

  • Much of the flakiness seems to be that the contact status wasn't being mocked correctly. If the contact status was in the partner care phase, the suggested status checkbox would be hidden.
  • I also memoized contactStatuses since it was used in a dependency array in SuggestedContactStatus.

MPDX-8363

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac self-assigned this Oct 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against d34020f

No significant changes found

@canac canac force-pushed the 8363-flaky-test branch 6 times, most recently from 8a4b4bd to 58aa8a7 Compare October 7, 2024 21:10
@canac canac requested a review from dr-bizz October 7, 2024 21:19
dr-bizz
dr-bizz approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@canac canac merged commit a897bcc into main Oct 8, 2024
18 checks passed
@canac canac deleted the 8363-flaky-test branch October 8, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

Assignees

@canac canac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canac @dr-bizz