Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Late Commitments #1121

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Fix Late Commitments #1121

merged 2 commits into from
Oct 8, 2024

Conversation

caleballdrin
Copy link
Contributor

@caleballdrin caleballdrin commented Oct 8, 2024

Description

https://secure.helpscout.net/mailbox/2c1fe7d687998a44/7669074/
https://secure.helpscout.net/conversation/2725829190/1238582?folderId=7669074

Issue:
Right now the API returns the first 3 late commitments (anything that is even 1 day late). Then the FE hides late commitments that are less than 7 days late. So sometimes those 3 late commitments get filtered out and it shows that there are no late commitments.

Fix:

  • Remove front-end filtering
  • Make the API only get commitments that are at least 30 days late. (This is how angular did it)

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Bundle sizes [mpdx-react]

Compared against a897bcc

No significant changes found

@caleballdrin caleballdrin self-assigned this Oct 8, 2024
@caleballdrin caleballdrin requested a review from canac October 8, 2024 15:32
@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Preview branch generated at https://helpscout-late-commitments.d3dytjb8adxkk5.amplifyapp.com

@wrandall22
Copy link
Contributor

What if we only filtered if there are at least 3 results?

@caleballdrin
Copy link
Contributor Author

What if we only filtered if there are at least 3 results?

We could. But I think this way is more simple. The angular site only showed commitments that were at least 30 days late. And then it also linked to the contacts page with a filter for contacts at least 30 days late.

Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I like that we're letting the server do the filtering work.

@caleballdrin caleballdrin merged commit b8a8d5a into main Oct 8, 2024
20 checks passed
@caleballdrin caleballdrin deleted the helpscout-late-commitments branch October 8, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants