Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPDX-8365 Coaching-dates #1122

Merged
merged 2 commits into from
Oct 9, 2024
Merged

MPDX-8365 Coaching-dates #1122

merged 2 commits into from
Oct 9, 2024

Conversation

caleballdrin
Copy link
Contributor

Description

https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8365&sprint=1276#

  • Format dates correctly
  • subtract one day from start date on Activity so it starts on sunday

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin self-assigned this Oct 9, 2024
@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Oct 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Preview branch generated at https://MPDX-8365-coaching-dates.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Bundle sizes [mpdx-react]

Compared against b8a8d5a

No significant changes found

@caleballdrin caleballdrin requested a review from canac October 9, 2024 15:26
canac
canac approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

src/components/Coaching/CoachingDetail/Activity/Activity.tsx Show resolved Hide resolved
@caleballdrin caleballdrin merged commit 4f6dc60 into main Oct 9, 2024
19 checks passed
@caleballdrin caleballdrin deleted the MPDX-8365-coaching-dates branch October 9, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canac canac canac approved these changes

Assignees

@caleballdrin caleballdrin

Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caleballdrin @canac