Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8373 Task Row #1139

Merged
merged 12 commits into from
Oct 24, 2024
Merged

MPDX-8373 Task Row #1139

merged 12 commits into from
Oct 24, 2024

Conversation

caleballdrin
Copy link
Contributor

@caleballdrin caleballdrin commented Oct 17, 2024

Description

https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8373&sprint=1276#

  • Move duplicate Task Phase/Action text to new component
  • Add tags and tag icon hover based on screen width
  • Add assignee Avatar with tooltip
  • Make task subject shorten with ellipses on main task list
  • Task List has condensed double lines on all screen sizes

Other unrelated fixes

  • Add hover to check boxes on Contact Task rows
  • Add selected count to Contact Tasks tab
  • Stop autofilling assignee when editing a task that was created without one.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Bundle sizes [mpdx-react]

Compared against ad47379

Route Size (gzipped) Diff
/accountLists/[accountListId]/tasks/[[...contactId]] 147.02 KB +9.56 KB
/accountLists/[accountListId]/tools/fix/commitmentInfo/[[...contactId]] 253.9 KB +4.19 KB
Dynamic import Size (gzipped) Diff
../src/components/Contacts/ContactsRightPanel/DynamicContactsRightPanel.tsx -> ./ContactsRightPanel 136.75 KB +4.57 KB

@caleballdrin caleballdrin self-assigned this Oct 17, 2024
@caleballdrin caleballdrin requested a review from canac October 17, 2024 01:48
@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Oct 17, 2024
Copy link
Contributor

Preview branch generated at https://MPDX-8373-task-row.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some great improvements! My main concern is that its now showing the task rows in condensed mode even without the contact details panel open.

@caleballdrin caleballdrin requested a review from canac October 24, 2024 16:08
@caleballdrin caleballdrin merged commit 0162a33 into main Oct 24, 2024
17 of 18 checks passed
@caleballdrin caleballdrin deleted the MPDX-8373-task-row branch October 24, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants