Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-Jira] Improve impersonation labels #1140

Merged
merged 2 commits into from
Oct 17, 2024
Merged

[no-Jira] Improve impersonation labels #1140

merged 2 commits into from
Oct 17, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Oct 17, 2024

Description

  • The old message had "MPDX" hardcoded and was inaccurate since we don't redirect to the legacy MPDX anymore.
  • The impersonation page tells you to click the "Exit Impersonation Mode" button but the button is actually called "Stop Impersonating".

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac requested a review from dr-bizz October 17, 2024 14:31
@canac canac self-assigned this Oct 17, 2024
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 90fa9f6

No significant changes found

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catches!

@canac canac merged commit ff5531a into main Oct 17, 2024
17 checks passed
@canac canac deleted the impersonation-message branch October 17, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants