-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPDX-8392 - Fix print styles #1144
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,6 +30,17 @@ const PrintableTableSortLabel = styled(TableSortLabel)(() => ({ | |
}, | ||
})); | ||
|
||
const TableCell = styled(StyledTableCell)(() => ({ | ||
top: 65, | ||
position: 'sticky', | ||
'@media print': { | ||
position: 'static', | ||
top: 0, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure where it is in the code, but could you make the name link black instead of blue when printing? That is how it is on the old angular site. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good call, I updated it. |
||
paddingTop: 0, | ||
paddingBottom: 0, | ||
}, | ||
})); | ||
|
||
const HeadCellSpan = styled('span')(() => ({ | ||
border: 0, | ||
clip: 'rect(0 0 0 0)', | ||
|
@@ -54,11 +65,7 @@ export const TableHeadCell: React.FC<FourteenMonthReportTableCellProps> = ({ | |
onClick, | ||
}) => { | ||
return ( | ||
<StyledTableCell | ||
align={align} | ||
sortDirection={sortDirection} | ||
style={{ top: 65 }} | ||
> | ||
<TableCell align={align} sortDirection={sortDirection}> | ||
<PrintableTableSortLabel | ||
active={isActive} | ||
direction={direction} | ||
|
@@ -71,6 +78,6 @@ export const TableHeadCell: React.FC<FourteenMonthReportTableCellProps> = ({ | |
</HeadCellSpan> | ||
)} | ||
</PrintableTableSortLabel> | ||
</StyledTableCell> | ||
</TableCell> | ||
); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this looks great! I wonder if you could also make the main header "Contributions By Partner Currency" have less margin/padding so it doesn't take up so much space.