Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX 8403 - Fix email exports to export the correct emails #1147

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Oct 22, 2024

Description

A user pointed out that we aren't exporting all the people's emails under each contact when exporting the newsletter email list on the dashboard.
Upon investigating, Scott Michell found that in addition to the above, when you export emails using the bulk action, it includes all the people's emails even if they have opted out.

HelpScout: https://secure.helpscout.net/conversation/2740763718/1246535/
Jira: https://jira.cru.org/browse/MPDX-8403

Changes

  1. On the export email bulk action on the contacts page, we only include people's email addresses who have not opted out of the digital newsletter.
  2. The e-mail Newsletter list now pulls all the people under each contact, as long as they haven't asked to be opted out of the digital newsletter.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz requested a review from caleballdrin October 22, 2024 18:20
@dr-bizz dr-bizz added the Preview Environment Add this label to create an Amplify Preview label Oct 22, 2024
Copy link
Contributor

Preview branch generated at https://MPDX-8403.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 0b3c384

No significant changes found

Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I tried it out and it is working.

@dr-bizz dr-bizz merged commit 5ade3d4 into main Oct 23, 2024
19 checks passed
@dr-bizz dr-bizz deleted the MPDX-8403 branch October 23, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants