MPDX-8383 - Complete Task Modal - preselect result

[wjames111]

Description

• Jira Ticket 8383
• Description: In the complete task modal, if there is only one task result option, we can preselect it to speed up completing tasks for users.

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
• I have requested a review from another person on the project

[github-actions]

Preview branch generated at https://MPDX-8383-preselect-single-task.d3dytjb8adxkk5.amplifyapp.com

[github-actions]

Bundle sizes [mpdx-react]

Compared against 0162a33

No significant changes found

[dr-bizz]

This is great! Thank you for fixing it so fast!

[canac]

I don't think this is quite right. It shows the correct value in the UI but doesn't seem to actually select it because displayResult is being sent as null.

It also isn't showing the Next Action autocomplete.

[wjames111]

@canac good catch, what about something like this. I'm sure there's a better way but I can't think of anything at the moment.
useEffect(() => { if (availableResults.length === 1) { handleResultChange({ result: availableResults[0], setFieldValue, setResultSelected, phaseData, }); } }, [availableResults]);

[canac]

@wjames111 Yeah, I think that's exactly what you'll want to do.

[canac]

Almost there!

[canac]

The getByRole for the value check is enough to also assert that it is in the document.

Suggested change

	expect(getByRole('combobox', { name: 'Result' })).toBeInTheDocument();
	expect(getByRole('combobox', { name: 'Result' })).toHaveValue('Attempted');
	expect(getByRole('combobox', { name: 'Result' })).toHaveValue('Attempted');

[canac]

I think this change is causing an error when I try to add or edit a task:

Variable $attributes of type TaskUpdateInput! was provided invalid value for displayResult (Expected "" to be one of: INITIATION_RESULT_NO_RESPONSE, INITIATION_RESULT_CIRCLE_BACK, INITIATION_RESULT_APPOINTMENT_SCHEDULED, INITIATION_RESULT_NOT_INTERESTED, FOLLOW_UP_RESULT_NO_RESPONSE, FOLLOW_UP_RESULT_PARTNER_FINANCIAL, FOLLOW_UP_RESULT_PARTNER_SPECIAL, FOLLOW_UP_RESULT_PARTNER_PRAY, FOLLOW_UP_RESULT_NOT_INTERESTED, APPOINTMENT_RESULT_CANCELLED, APPOINTMENT_RESULT_FOLLOW_UP, APPOINTMENT_RESULT_PARTNER_FINANCIAL, APPOINTMENT_RESULT_PARTNER_SPECIAL, APPOINTMENT_RESULT_PARTNER_PRAY, APPOINTMENT_RESULT_NOT_INTERESTED, PARTNER_CARE_COMPLETED)

[wjames111]

So for some reason leaving it as undefined breaks it and I can't quite figure out why.

[wjames111]

Specifically on Log Task.

[canac]

@wjames111 I think we can fix the bug where the result is populated before the user picks an action by passing an empty array to availableResults when the activityType is missing.

Sorry, I thought you had requested another review. I'm sure you were going to get to that bug, but I'm just mentioning what I found since I already spent the time looking at the code.

The rest looks great once you get all the tests passing again!

diff --git a/src/components/Task/Modal/Form/Complete/TaskModalCompleteForm.tsx b/src/components/Task/Modal/Form/Complete/TaskModalCompleteForm.tsx
index 7b38566fc..d572c847a 100644
--- a/src/components/Task/Modal/Form/Complete/TaskModalCompleteForm.tsx
+++ b/src/components/Task/Modal/Form/Complete/TaskModalCompleteForm.tsx
@@ -350,7 +350,7 @@ const TaskModalCompleteForm = ({
               </Grid>
 
               <ResultAutocomplete
-                availableResults={availableResults}
+                availableResults={activityType ? availableResults : []}
                 result={displayResult}
                 setFieldValue={setFieldValue}
                 setResultSelected={setResultSelected}
diff --git a/src/components/Task/Modal/Form/LogForm/TaskModalLogForm.tsx b/src/components/Task/Modal/Form/LogForm/TaskModalLogForm.tsx
index 98babc1e2..fcf96c4e4 100644
--- a/src/components/Task/Modal/Form/LogForm/TaskModalLogForm.tsx
+++ b/src/components/Task/Modal/Form/LogForm/TaskModalLogForm.tsx
@@ -421,7 +421,7 @@ const TaskModalLogForm = ({
               )}
 
               <ResultAutocomplete
-                availableResults={availableResults}
+                availableResults={activityType ? availableResults : []}
                 result={displayResult}
                 setFieldValue={setFieldValue}
                 setResultSelected={setResultSelected}
diff --git a/src/components/Task/Modal/Form/TaskModalForm.tsx b/src/components/Task/Modal/Form/TaskModalForm.tsx
index fbf817d9b..aa4920862 100644
--- a/src/components/Task/Modal/Form/TaskModalForm.tsx
+++ b/src/components/Task/Modal/Form/TaskModalForm.tsx
@@ -583,7 +583,7 @@ const TaskModalForm = ({
               </Grid>
               {initialTask.completedAt && (
                 <ResultAutocomplete
-                  availableResults={availableResults}
+                  availableResults={activityType ? availableResults : []}
                   result={displayResult}
                   setFieldValue={setFieldValue}
                   setResultSelected={setResultSelected}

[wjames111]

@canac sorry didn't mean to request your review yet. But thank you, that is a much easier solution then I was thinking.

[wjames111]

@canac I did notice that the Result autocomplete is hidden while availableResults is empty. Not sure how often users would need to skip down the form but if it's an issue I could just check for the activityType in the useEffect.

[canac]

This is great! As a user, I'm looking forward to saving some clicks when I complete tasks!