-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPDX-8405] Fix filtering the map by selected contacts #1154
Conversation
Preview branch generated at https://8405-filter-map.d3dytjb8adxkk5.amplifyapp.com |
useUserPreference({ | ||
key: 'contacts_view', | ||
defaultValue: TableViewModeEnum.List, | ||
}); | ||
useEffect(() => { | ||
if (contactsView && !userOptionsLoading) { | ||
if (contactsView) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dr-bizz When I asked you to add this additional check, I was mistaken. I thought this effect saved the user preference, but it is just updating the view mode in the contacts wrapper. It was right how you had it first, so I'm switching it back.
Bundle sizes [mpdx-react]Compared against 9f1e8f2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks great, but more contacts are showing on the map than I expected. I thought only 3 (the same number of the contacts I had on the list view) would show up on maps.
switching-list-to-map.mov
pages/accountLists/[accountListId]/contacts/ContactsWrapper.tsx
Outdated
Show resolved
Hide resolved
e75e665
to
9faf3d6
Compare
Description
ContactsContext
tests to use a reusable wrapper.Testing
MPDX-8405
Checklist: