Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8389 Replace hardcoded help link #1156

Merged
merged 4 commits into from
Oct 24, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pages/login.page.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,10 @@ describe('Login - OKTA', () => {
name: /find help/i,
});
await waitFor(() => {
expect(findHelpLink).toHaveAttribute('href', 'https://help.mpdx.org');
expect(findHelpLink).toHaveAttribute(
'href',
process.env.HELPJUICE_KNOWLEDGE_BASE_URL,
caleballdrin marked this conversation as resolved.
Show resolved Hide resolved
);
});
});
});
Expand Down
6 changes: 5 additions & 1 deletion pages/login.page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,11 @@ const Login = ({
<Button
size="large"
startIcon={<SubjectIcon />}
href="https://help.mpdx.org"
href={
caleballdrin marked this conversation as resolved.
Show resolved Hide resolved
process.env.HELPJUICE_KNOWLEDGE_BASE_URL ||
process.env.HELPJUICE_ORIGIN ||
''
}
target="_blank"
rel="noopener noreferrer"
style={{ color: '#fff' }}
Expand Down
6 changes: 5 additions & 1 deletion src/components/Welcome/Welcome.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@ export const Default = ({
<Button
size="large"
startIcon={<SubjectIcon />}
href="https://help.mpdx.org"
href={
process.env.HELPJUICE_KNOWLEDGE_BASE_URL ||
process.env.HELPJUICE_ORIGIN ||
''
}
target="_blank"
rel="noopener noreferrer"
style={{ color: '#fff' }}
Expand Down
Loading