Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-Jira] Fix disabled tooltip button warning #1157

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

canac
Copy link
Contributor

@canac canac commented Oct 24, 2024

Description

Fix MUI warning:

You are providing a disabled button child to the Tooltip component.
A disabled element does not fire events.
Tooltip needs to listen to the child element's events to display the title.

I went with the simple fix, but I could see a case for hiding the reverse button entirely instead of disabling it to reduce some clutter. This could be good since there are already so many different elements in the filter panel. Let me know your thoughts.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Oct 24, 2024
@canac canac requested review from caleballdrin and dr-bizz October 24, 2024 19:58
@canac canac self-assigned this Oct 24, 2024
Copy link
Contributor

Preview branch generated at https://disabled-tooltip-button.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 0162a33

No significant changes found

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this warning

@canac canac merged commit 6c3cb0b into main Oct 25, 2024
19 checks passed
@canac canac deleted the disabled-tooltip-button branch October 25, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants