Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPDX-8413 - Appeal contact row actions click fix #1159

Merged
merged 1 commit into from
Oct 28, 2024
Merged

MPDX-8413 - Appeal contact row actions click fix #1159

merged 1 commit into from
Oct 28, 2024

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Oct 28, 2024 •
edited
Loading

Description

HelpScout Ticket: 1248886
Jira: MPDX-8413

Fix the appeal contact row click to prevent it from opening contact when clicking on action icons.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz requested a review from canac October 28, 2024 13:24
@dr-bizz dr-bizz added the Preview Environment Add this label to create an Amplify Preview label Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview branch generated at https://hs-1248886-appeal-commitment.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against fb060bb

No significant changes found

canac
canac approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

src/components/Tool/Appeal/List/ContactRow/ContactRow.test.tsx
</ThemeProvider>
</GqlMockedProvider>
<LocalizationProvider dateAdapter={AdapterLuxon}>
<SnackbarProvider>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need the <SnackbarProvider> or to mock the notistack import but not both.

@dr-bizz dr-bizz force-pushed the hs-1248886-appeal-commitment branch from 999ee2e to 0af946c Compare October 28, 2024 15:38
@dr-bizz dr-bizz enabled auto-merge October 28, 2024 15:38
@dr-bizz dr-bizz merged commit 54916e3 into main Oct 28, 2024
17 of 18 checks passed
@dr-bizz dr-bizz deleted the hs-1248886-appeal-commitment branch October 28, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canac canac canac approved these changes

Assignees
No one assigned
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dr-bizz @canac