Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-7900 Remove Header image and make smaller #1164

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

caleballdrin
Copy link
Contributor

Description

https://jira.cru.org/browse/MPDX-7900

  • remove header image and empty space

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Oct 30, 2024
@caleballdrin caleballdrin self-assigned this Oct 30, 2024
@caleballdrin caleballdrin requested a review from canac October 30, 2024 16:00
Copy link
Contributor

Preview branch generated at https://MPDX-7900-header-space.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against f442ffa

Route Size (gzipped) Diff
/accountLists/[accountListId] 268.54 KB -4.03 KB

@@ -2,7 +2,6 @@ import React, { ReactElement } from 'react';
import { DateTime } from 'luxon';
import { useTranslation } from 'react-i18next';
import useGetAppSettings from 'src/hooks/useGetAppSettings';
import illustration9 from '../../../images/drawkit/grape/drawkit-grape-pack-illustration-9.svg';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to suggest deleting this image from the repo too, but there are some illustrations that aren't being used, so it's probably fine.

@caleballdrin caleballdrin merged commit 212186c into main Oct 30, 2024
19 checks passed
@caleballdrin caleballdrin deleted the MPDX-7900-header-space branch October 30, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants