Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPDX-8406] Add contact panel to expected monthly total report #1165

Merged
merged 4 commits into from
Oct 31, 2024
Merged

[MPDX-8406] Add contact panel to expected monthly total report #1165

merged 4 commits into from
Oct 31, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Oct 30, 2024

Description

Add a contact right panel to the expected monthly total report so that clicking on a contact opens it there instead of going to the contacts list.

MPDX-8406

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Oct 30, 2024
@canac canac requested a review from dr-bizz October 30, 2024 21:35
@canac canac self-assigned this Oct 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview branch generated at https://8406-expected-monthly-total-contact-panel.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against 121cd06

Route Size (gzipped) Diff
/accountLists/[accountListId]/reports/expectedMonthlyTotal/[[...contactId]] 130.45 KB added
/accountLists/[accountListId]/reports/expectedMonthlyTotal no change removed

dr-bizz
dr-bizz approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment about how you could reduce your code, but it looks great so I will approve it.

src/components/Reports/ExpectedMonthlyTotalReport/Table/ExpectedMonthlyTotalReportTable.tsx Outdated Show resolved Hide resolved
...components/Reports/ExpectedMonthlyTotalReport/Table/ExpectedMonthlyTotalReportTable.test.tsx Outdated Show resolved Hide resolved
@canac canac merged commit f66ea2e into main Oct 31, 2024
18 checks passed
@canac canac deleted the 8406-expected-monthly-total-contact-panel branch October 31, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

Assignees

@canac canac

Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canac @dr-bizz