Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPDX-8421 14month Late Circle #1167

Merged
merged 2 commits into from
Oct 31, 2024
Merged

MPDX-8421 14month Late Circle #1167

merged 2 commits into from
Oct 31, 2024

Conversation

caleballdrin
Copy link
Contributor

Description

https://jira.cru.org/browse/MPDX-8421

  • Add colored circle if the partner is late on their giving.
  • Hide it on print view

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin self-assigned this Oct 31, 2024
@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Oct 31, 2024
@caleballdrin caleballdrin requested a review from canac October 31, 2024 19:36
@github-actions GitHub Actions
Copy link
Contributor

Preview branch generated at https://14month-circle.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 9d15d74

No significant changes found

canac
canac requested changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tooltip!

src/components/Reports/FourteenMonthReports/Layout/Table/Table.tsx Outdated Show resolved Hide resolved
src/components/Reports/FourteenMonthReports/Layout/Table/Table.test.tsx Outdated Show resolved Hide resolved
src/components/Reports/FourteenMonthReports/Layout/Table/Table.test.tsx Outdated Show resolved Hide resolved
canac
canac approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixup!

@caleballdrin caleballdrin merged commit f46ff6f into main Oct 31, 2024
18 checks passed
@caleballdrin caleballdrin deleted the 14month-circle branch October 31, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canac canac canac approved these changes

Assignees

@caleballdrin caleballdrin

Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caleballdrin @canac